From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 2/3] ide-cd: cleanup cdrom_decode_status Date: Fri, 3 Apr 2009 12:41:44 +0200 Message-ID: <200904031241.44597.bzolnier@gmail.com> References: <1238655519-10074-2-git-send-email-petkovbb@gmail.com> <200904030108.39927.bzolnier@gmail.com> <20090403045803.GA3732@liondog.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: Received: from ey-out-2122.google.com ([74.125.78.26]:27669 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762943AbZDCKiQ (ORCPT ); Fri, 3 Apr 2009 06:38:16 -0400 In-Reply-To: <20090403045803.GA3732@liondog.tnic> Content-Disposition: inline Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: petkovbb@gmail.com Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org On Friday 03 April 2009, Borislav Petkov wrote: > Hi, > > On Fri, Apr 03, 2009 at 01:08:39AM +0200, Bartlomiej Zolnierkiewicz wrote: > > On Thursday 02 April 2009, Borislav Petkov wrote: > > > - have (almost) equal handling of commands based solely on sense_key > > > > I'm having a VERY hard time trying to review this patch because at > > the same time that codepaths were merged if()s were replaced by switch() > > which in turn resulted in change of intendation... on top of that > > the patch description is very vague about this part of the changes... > > I completely and exactly understand what you are saying :), I thought so > too when I looked at the diffs yesterday. Well, if it's any consolation, the > patches've been tested so they seem to work :). Anyway, split version coming > up... The split version looks exactly the same except ide_cd_breathe() change when it comes to the main part. Did you send the wrong version by any chance?