From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: petkovbb@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH 2/3] ide-cd: cleanup cdrom_decode_status
Date: Sat, 4 Apr 2009 14:17:20 +0200 [thread overview]
Message-ID: <200904041417.21125.bzolnier@gmail.com> (raw)
In-Reply-To: <20090403045803.GA3732@liondog.tnic>
On Friday 03 April 2009, Borislav Petkov wrote:
[...]
> > > @@ -614,14 +589,15 @@ static ide_startstop_t cdrom_newpc_intr(ide_drive_t *drive)
> > > struct request *rq = hwif->rq;
> > > ide_expiry_t *expiry = NULL;
> > > int dma_error = 0, dma, thislen, uptodate = 0;
> > > - int write = (rq_data_dir(rq) == WRITE) ? 1 : 0, rc, nsectors;
> > > + int write, uninitialized_var(rc), nsectors;
> >
> > Why is uninitialized_var() here now?
>
> because gcc is whining that it might be uninitialized although I've
> doublechecked all codepaths returning a valid error. It is there to shut
> up this warning, actually.
It is gcc's fault (version dependent on top of it). However since it may
affect other people and workarounding it costs us absolutely nothing lets
be pragmatic about it.
Please resend this change in a separate patch so it can be applied.
next prev parent reply other threads:[~2009-04-04 12:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-02 6:58 [PATCH 2/3] ide-cd: cleanup cdrom_decode_status Borislav Petkov
2009-04-02 23:08 ` Bartlomiej Zolnierkiewicz
2009-04-03 4:58 ` Borislav Petkov
2009-04-03 10:41 ` Bartlomiej Zolnierkiewicz
2009-04-03 14:03 ` Borislav Petkov
2009-04-03 19:39 ` Bartlomiej Zolnierkiewicz
2009-04-04 9:40 ` Borislav Petkov
2009-04-04 12:00 ` Bartlomiej Zolnierkiewicz
2009-04-04 12:17 ` Bartlomiej Zolnierkiewicz [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-04-03 7:58 Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904041417.21125.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=petkovbb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).