Re: [PATCH 4/6] PalmLD IDE

Re: [PATCH 4/6] PalmLD IDE

[Marek Vasut]

[-- Attachment #1: Type: text/plain, Size: 728 bytes --]

Dne Saturday 16 of August 2008 11:08:03 Russell King - ARM Linux napsal(a):
> On Wed, Aug 13, 2008 at 10:52:23PM +0200, Marek Vasut wrote:
> > This patch adds palmld ide channel support, same as previous patch, I
> > think this can be merged since it wont break anything.
>
> I think this one also needs review by the Linux ATA folk.  Mention to
> them that it's part of a patchset for ARM and that you'd prefer it
> to be merged into the ARM tree.
>
> > +static const char drvname[] = "pata_palmld";
> > +MODULE_ALIAS("platform: "drvname);
>
> Have you tried building this as a module?  Also, IIRC, there isn't
> supposed to be a space after the colon...

Ok, I fixed the issues and CCed linux-ide and the maintainer.

Thanks


[-- Attachment #2: 0004-PalmLD-IDE-support.patch --]
[-- Type: text/x-diff, Size: 5500 bytes --]

From 8881f9cbf66a3050de328f6c020f864ca04c1e9b Mon Sep 17 00:00:00 2001
From: Marek <marek.vasut@gmail.com>
Date: Sat, 16 Aug 2008 16:25:34 +0200
Subject: [PATCH] PalmLD: IDE support
 Support for Palm LifeDrive's internal harddrive

---
 drivers/ata/Kconfig       |    9 +++
 drivers/ata/Makefile      |    1 +
 drivers/ata/pata_palmld.c |  145 +++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 155 insertions(+), 0 deletions(-)
 create mode 100644 drivers/ata/pata_palmld.c

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index ae84949..8e43d11 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -533,6 +533,15 @@ config PATA_OPTIDMA
 
 	  If unsure, say N.
 
+config PATA_PALMLD
+	tristate "Palm LifeDrive PATA support"
+	depends on MACH_PALMLD
+	help
+	  This option enables support for Palm LifeDrive's internal ATA
+	  port via the new ATA layer.
+
+	  If unsure, say N.
+
 config PATA_PCMCIA
 	tristate "PCMCIA PATA support"
 	depends on PCMCIA
diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
index 674965f..2b393c9 100644
--- a/drivers/ata/Makefile
+++ b/drivers/ata/Makefile
@@ -50,6 +50,7 @@ obj-$(CONFIG_PATA_MPC52xx)	+= pata_mpc52xx.o
 obj-$(CONFIG_PATA_MARVELL)	+= pata_marvell.o
 obj-$(CONFIG_PATA_MPIIX)	+= pata_mpiix.o
 obj-$(CONFIG_PATA_OLDPIIX)	+= pata_oldpiix.o
+obj-$(CONFIG_PATA_PALMLD)	+= pata_palmld.o
 obj-$(CONFIG_PATA_PCMCIA)	+= pata_pcmcia.o
 obj-$(CONFIG_PATA_PDC2027X)	+= pata_pdc2027x.o
 obj-$(CONFIG_PATA_PDC_OLD)	+= pata_pdc202xx_old.o
diff --git a/drivers/ata/pata_palmld.c b/drivers/ata/pata_palmld.c
new file mode 100644
index 0000000..f0693f8
--- /dev/null
+++ b/drivers/ata/pata_palmld.c
@@ -0,0 +1,145 @@
+/*
+ * drivers/ata/pata_palmld.c
+ *
+ * Driver for IDE channel in Palm LifeDrive
+ *
+ * Based on research of:
+ *		Alex Osborne <ato@meshy.org>
+ *
+ * Rewrite for mainline:
+ *		Marek Vasut <marek.vasut@gmail.com>
+ *
+ * Rewritten version based on pata_ixp4xx_cf.c:
+ * ixp4xx PATA/Compact Flash driver
+ * Copyright (C) 2006-07 Tower Technologies
+ * Author: Alessandro Zummo <a.zummo@towertech.it>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ */
+
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/libata.h>
+#include <linux/irq.h>
+#include <linux/platform_device.h>
+#include <linux/delay.h>
+#include <linux/gpio.h>
+
+#include <scsi/scsi_host.h>
+#include <mach/palmld.h>
+
+#define DRV_NAME "pata_palmld"
+
+static struct scsi_host_template palmld_sht = {
+	ATA_PIO_SHT(DRV_NAME),
+};
+
+static struct ata_port_operations palmld_port_ops = {
+	.inherits		= &ata_sff_port_ops,
+	.sff_data_xfer		= ata_sff_data_xfer_noirq,
+	.cable_detect		= ata_cable_40wire,
+};
+
+static __devinit int palmld_pata_probe(struct platform_device *pdev)
+{
+	struct ata_host *host;
+	struct ata_port *ap;
+	void __iomem *mem;
+	int ret;
+
+	/* allocate host */
+	host = ata_host_alloc(&pdev->dev, 1);
+	if (!host)
+		return -ENOMEM;
+
+	/* remap drive's physical memory address */
+	mem = devm_ioremap(&pdev->dev, PALMLD_IDE_PHYS, 0x1000);
+	if (!mem)
+		return -ENOMEM;
+
+	/* request and activate power GPIO, IRQ GPIO */
+	ret = gpio_request(GPIO_NR_PALMLD_IDE_PWEN, "HDD PWR");
+	if (ret)
+		goto err1;
+	ret = gpio_direction_output(GPIO_NR_PALMLD_IDE_PWEN, 1);
+	if (ret)
+		goto err2;
+
+	ret = gpio_request(GPIO_NR_PALMLD_IDE_IRQ, "HDD IRQ");
+	if (ret)
+		goto err2;
+	ret = gpio_direction_input(GPIO_NR_PALMLD_IDE_IRQ);
+	if (ret)
+		goto err3;
+
+	/* we'd better wait for drive's ready signal here
+	  (if we knew where it will come from) */
+	msleep(300);
+
+	/* setup the ata port */
+	ap = host->ports[0];
+	ap->ops	= &palmld_port_ops;
+	ap->pio_mask = ATA_PIO4;
+	ap->flags |= ATA_FLAG_MMIO | ATA_FLAG_NO_LEGACY | ATA_FLAG_NO_ATAPI;
+
+	/* memory mapping voodoo */
+	ap->ioaddr.cmd_addr = mem + 0x10;
+	ap->ioaddr.altstatus_addr = mem + 0xe;
+	ap->ioaddr.ctl_addr = mem + 0xe;
+
+	/* start the port */
+	ata_sff_std_ports(&ap->ioaddr);
+
+	/* activate host */
+	return ata_host_activate(host, gpio_to_irq(GPIO_NR_PALMLD_IDE_IRQ),
+					ata_sff_interrupt, IRQF_TRIGGER_RISING,
+					&palmld_sht);
+err3:
+	gpio_free(GPIO_NR_PALMLD_IDE_IRQ);
+err2:
+	gpio_free(GPIO_NR_PALMLD_IDE_PWEN);
+err1:
+	return ret;
+}
+
+static __devexit int palmld_pata_remove(struct platform_device *dev)
+{
+	struct ata_host *host = platform_get_drvdata(dev);
+
+	ata_host_detach(host);
+
+	gpio_free(GPIO_NR_PALMLD_IDE_PWEN);
+	gpio_free(GPIO_NR_PALMLD_IDE_IRQ);
+
+	return 0;
+}
+
+static struct platform_driver palmld_pata_platform_driver = {
+	.driver	 = {
+		.name   = DRV_NAME,
+		.owner  = THIS_MODULE,
+	},
+	.probe		= palmld_pata_probe,
+	.remove		= __devexit_p(palmld_pata_remove),
+};
+
+static int __init palmld_pata_init(void)
+{
+	return platform_driver_register(&palmld_pata_platform_driver);
+}
+
+static void __exit palmld_pata_exit(void)
+{
+	platform_driver_unregister(&palmld_pata_platform_driver);
+}
+
+MODULE_AUTHOR("Marek Vasut <marek.vasut@gmail.com>");
+MODULE_DESCRIPTION("PalmLD PATA driver");
+MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:" DRV_NAME);
+
+module_init(palmld_pata_init);
+module_exit(palmld_pata_exit);
-- 
1.5.6

Re: [PATCH 4/6] PalmLD IDE

[Marek Vasut]

[-- Attachment #1: Type: text/plain, Size: 947 bytes --]

> Dne Saturday 16 of August 2008 11:08:03 Russell King - ARM Linux napsal(a):
> > On Wed, Aug 13, 2008 at 10:52:23PM +0200, Marek Vasut wrote:
> > > This patch adds palmld ide channel support, same as previous patch, I
> > > think this can be merged since it wont break anything.
> >
> > I think this one also needs review by the Linux ATA folk.  Mention to
> > them that it's part of a patchset for ARM and that you'd prefer it
> > to be merged into the ARM tree.
> >
> > > +static const char drvname[] = "pata_palmld";
> > > +MODULE_ALIAS("platform: "drvname);
> >
> > Have you tried building this as a module?  Also, IIRC, there isn't
> > supposed to be a space after the colon...
> 
> Ok, I fixed the issues and CCed linux-ide and the maintainer.
> 
> Thanks

Hi, Im resending this patch since it was totally ignored last time. It still 
applies correctly. It'd be for the best to push this through arm-kernel tree.

Best regards
Marek Vasut


[-- Attachment #2: 0004-PalmLD-IDE-support.patch --]
[-- Type: text/x-diff, Size: 5500 bytes --]

From 8881f9cbf66a3050de328f6c020f864ca04c1e9b Mon Sep 17 00:00:00 2001
From: Marek <marek.vasut@gmail.com>
Date: Sat, 16 Aug 2008 16:25:34 +0200
Subject: [PATCH] PalmLD: IDE support
 Support for Palm LifeDrive's internal harddrive

---
 drivers/ata/Kconfig       |    9 +++
 drivers/ata/Makefile      |    1 +
 drivers/ata/pata_palmld.c |  145 +++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 155 insertions(+), 0 deletions(-)
 create mode 100644 drivers/ata/pata_palmld.c

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index ae84949..8e43d11 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -533,6 +533,15 @@ config PATA_OPTIDMA
 
 	  If unsure, say N.
 
+config PATA_PALMLD
+	tristate "Palm LifeDrive PATA support"
+	depends on MACH_PALMLD
+	help
+	  This option enables support for Palm LifeDrive's internal ATA
+	  port via the new ATA layer.
+
+	  If unsure, say N.
+
 config PATA_PCMCIA
 	tristate "PCMCIA PATA support"
 	depends on PCMCIA
diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
index 674965f..2b393c9 100644
--- a/drivers/ata/Makefile
+++ b/drivers/ata/Makefile
@@ -50,6 +50,7 @@ obj-$(CONFIG_PATA_MPC52xx)	+= pata_mpc52xx.o
 obj-$(CONFIG_PATA_MARVELL)	+= pata_marvell.o
 obj-$(CONFIG_PATA_MPIIX)	+= pata_mpiix.o
 obj-$(CONFIG_PATA_OLDPIIX)	+= pata_oldpiix.o
+obj-$(CONFIG_PATA_PALMLD)	+= pata_palmld.o
 obj-$(CONFIG_PATA_PCMCIA)	+= pata_pcmcia.o
 obj-$(CONFIG_PATA_PDC2027X)	+= pata_pdc2027x.o
 obj-$(CONFIG_PATA_PDC_OLD)	+= pata_pdc202xx_old.o
diff --git a/drivers/ata/pata_palmld.c b/drivers/ata/pata_palmld.c
new file mode 100644
index 0000000..f0693f8
--- /dev/null
+++ b/drivers/ata/pata_palmld.c
@@ -0,0 +1,145 @@
+/*
+ * drivers/ata/pata_palmld.c
+ *
+ * Driver for IDE channel in Palm LifeDrive
+ *
+ * Based on research of:
+ *		Alex Osborne <ato@meshy.org>
+ *
+ * Rewrite for mainline:
+ *		Marek Vasut <marek.vasut@gmail.com>
+ *
+ * Rewritten version based on pata_ixp4xx_cf.c:
+ * ixp4xx PATA/Compact Flash driver
+ * Copyright (C) 2006-07 Tower Technologies
+ * Author: Alessandro Zummo <a.zummo@towertech.it>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ */
+
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/libata.h>
+#include <linux/irq.h>
+#include <linux/platform_device.h>
+#include <linux/delay.h>
+#include <linux/gpio.h>
+
+#include <scsi/scsi_host.h>
+#include <mach/palmld.h>
+
+#define DRV_NAME "pata_palmld"
+
+static struct scsi_host_template palmld_sht = {
+	ATA_PIO_SHT(DRV_NAME),
+};
+
+static struct ata_port_operations palmld_port_ops = {
+	.inherits		= &ata_sff_port_ops,
+	.sff_data_xfer		= ata_sff_data_xfer_noirq,
+	.cable_detect		= ata_cable_40wire,
+};
+
+static __devinit int palmld_pata_probe(struct platform_device *pdev)
+{
+	struct ata_host *host;
+	struct ata_port *ap;
+	void __iomem *mem;
+	int ret;
+
+	/* allocate host */
+	host = ata_host_alloc(&pdev->dev, 1);
+	if (!host)
+		return -ENOMEM;
+
+	/* remap drive's physical memory address */
+	mem = devm_ioremap(&pdev->dev, PALMLD_IDE_PHYS, 0x1000);
+	if (!mem)
+		return -ENOMEM;
+
+	/* request and activate power GPIO, IRQ GPIO */
+	ret = gpio_request(GPIO_NR_PALMLD_IDE_PWEN, "HDD PWR");
+	if (ret)
+		goto err1;
+	ret = gpio_direction_output(GPIO_NR_PALMLD_IDE_PWEN, 1);
+	if (ret)
+		goto err2;
+
+	ret = gpio_request(GPIO_NR_PALMLD_IDE_IRQ, "HDD IRQ");
+	if (ret)
+		goto err2;
+	ret = gpio_direction_input(GPIO_NR_PALMLD_IDE_IRQ);
+	if (ret)
+		goto err3;
+
+	/* we'd better wait for drive's ready signal here
+	  (if we knew where it will come from) */
+	msleep(300);
+
+	/* setup the ata port */
+	ap = host->ports[0];
+	ap->ops	= &palmld_port_ops;
+	ap->pio_mask = ATA_PIO4;
+	ap->flags |= ATA_FLAG_MMIO | ATA_FLAG_NO_LEGACY | ATA_FLAG_NO_ATAPI;
+
+	/* memory mapping voodoo */
+	ap->ioaddr.cmd_addr = mem + 0x10;
+	ap->ioaddr.altstatus_addr = mem + 0xe;
+	ap->ioaddr.ctl_addr = mem + 0xe;
+
+	/* start the port */
+	ata_sff_std_ports(&ap->ioaddr);
+
+	/* activate host */
+	return ata_host_activate(host, gpio_to_irq(GPIO_NR_PALMLD_IDE_IRQ),
+					ata_sff_interrupt, IRQF_TRIGGER_RISING,
+					&palmld_sht);
+err3:
+	gpio_free(GPIO_NR_PALMLD_IDE_IRQ);
+err2:
+	gpio_free(GPIO_NR_PALMLD_IDE_PWEN);
+err1:
+	return ret;
+}
+
+static __devexit int palmld_pata_remove(struct platform_device *dev)
+{
+	struct ata_host *host = platform_get_drvdata(dev);
+
+	ata_host_detach(host);
+
+	gpio_free(GPIO_NR_PALMLD_IDE_PWEN);
+	gpio_free(GPIO_NR_PALMLD_IDE_IRQ);
+
+	return 0;
+}
+
+static struct platform_driver palmld_pata_platform_driver = {
+	.driver	 = {
+		.name   = DRV_NAME,
+		.owner  = THIS_MODULE,
+	},
+	.probe		= palmld_pata_probe,
+	.remove		= __devexit_p(palmld_pata_remove),
+};
+
+static int __init palmld_pata_init(void)
+{
+	return platform_driver_register(&palmld_pata_platform_driver);
+}
+
+static void __exit palmld_pata_exit(void)
+{
+	platform_driver_unregister(&palmld_pata_platform_driver);
+}
+
+MODULE_AUTHOR("Marek Vasut <marek.vasut@gmail.com>");
+MODULE_DESCRIPTION("PalmLD PATA driver");
+MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:" DRV_NAME);
+
+module_init(palmld_pata_init);
+module_exit(palmld_pata_exit);
-- 
1.5.6

Re: [PATCH 4/6] PalmLD IDE

[Marek Vasut]

On Sunday 22 of March 2009 22:23:10 Marek Vasut wrote:
> > Dne Saturday 16 of August 2008 11:08:03 Russell King - ARM Linux 
napsal(a):
> > > On Wed, Aug 13, 2008 at 10:52:23PM +0200, Marek Vasut wrote:
> > > > This patch adds palmld ide channel support, same as previous patch, I
> > > > think this can be merged since it wont break anything.
> > >
> > > I think this one also needs review by the Linux ATA folk.  Mention to
> > > them that it's part of a patchset for ARM and that you'd prefer it
> > > to be merged into the ARM tree.
> > >
> > > > +static const char drvname[] = "pata_palmld";
> > > > +MODULE_ALIAS("platform: "drvname);
> > >
> > > Have you tried building this as a module?  Also, IIRC, there isn't
> > > supposed to be a space after the colon...
> >
> > Ok, I fixed the issues and CCed linux-ide and the maintainer.
> >
> > Thanks
>
> Hi, Im resending this patch since it was totally ignored last time. It
> still applies correctly. It'd be for the best to push this through
> arm-kernel tree.
>
> Best regards
> Marek Vasut

It's still being totally ignored on both mailing lists ... why? Thanks

Re: [PATCH 4/6] PalmLD IDE

[Bartlomiej Zolnierkiewicz]

On Sunday 19 April 2009 18:14:05 Marek Vasut wrote:
> On Sunday 22 of March 2009 22:23:10 Marek Vasut wrote:
> > > Dne Saturday 16 of August 2008 11:08:03 Russell King - ARM Linux 
> napsal(a):
> > > > On Wed, Aug 13, 2008 at 10:52:23PM +0200, Marek Vasut wrote:
> > > > > This patch adds palmld ide channel support, same as previous patch, I
> > > > > think this can be merged since it wont break anything.
> > > >
> > > > I think this one also needs review by the Linux ATA folk.  Mention to
> > > > them that it's part of a patchset for ARM and that you'd prefer it
> > > > to be merged into the ARM tree.
> > > >
> > > > > +static const char drvname[] = "pata_palmld";
> > > > > +MODULE_ALIAS("platform: "drvname);
> > > >
> > > > Have you tried building this as a module?  Also, IIRC, there isn't
> > > > supposed to be a space after the colon...
> > >
> > > Ok, I fixed the issues and CCed linux-ide and the maintainer.
> > >
> > > Thanks
> >
> > Hi, Im resending this patch since it was totally ignored last time. It
> > still applies correctly. It'd be for the best to push this through
> > arm-kernel tree.
> >
> > Best regards
> > Marek Vasut
> 
> It's still being totally ignored on both mailing lists ... why? Thanks

I don't know the answer for your question but this patch is not for me.

Please take me off cc: list unless you're also going to submit *IDE* driver
(sorry, I have no time to review libata patches).  Thanks.

Re: [PATCH 4/6] PalmLD IDE

[Marek Vasut]

On Monday 20 of April 2009 22:38:38 Bartlomiej Zolnierkiewicz wrote:
> On Sunday 19 April 2009 18:14:05 Marek Vasut wrote:
> > On Sunday 22 of March 2009 22:23:10 Marek Vasut wrote:
> > > > Dne Saturday 16 of August 2008 11:08:03 Russell King - ARM Linux
> >
> > napsal(a):
> > > > > On Wed, Aug 13, 2008 at 10:52:23PM +0200, Marek Vasut wrote:
> > > > > > This patch adds palmld ide channel support, same as previous
> > > > > > patch, I think this can be merged since it wont break anything.
> > > > >
> > > > > I think this one also needs review by the Linux ATA folk.  Mention
> > > > > to them that it's part of a patchset for ARM and that you'd prefer
> > > > > it to be merged into the ARM tree.
> > > > >
> > > > > > +static const char drvname[] = "pata_palmld";
> > > > > > +MODULE_ALIAS("platform: "drvname);
> > > > >
> > > > > Have you tried building this as a module?  Also, IIRC, there isn't
> > > > > supposed to be a space after the colon...
> > > >
> > > > Ok, I fixed the issues and CCed linux-ide and the maintainer.
> > > >
> > > > Thanks
> > >
> > > Hi, Im resending this patch since it was totally ignored last time. It
> > > still applies correctly. It'd be for the best to push this through
> > > arm-kernel tree.
> > >
> > > Best regards
> > > Marek Vasut
> >
> > It's still being totally ignored on both mailing lists ... why? Thanks
>
> I don't know the answer for your question but this patch is not for me.
>
> Please take me off cc: list unless you're also going to submit *IDE* driver
> (sorry, I have no time to review libata patches).  Thanks.

That's good to know, where should I send it then? Thanks

Re: [PATCH 4/6] PalmLD IDE

[Bartlomiej Zolnierkiewicz]

On Monday 20 April 2009 22:53:06 Marek Vasut wrote:
> On Monday 20 of April 2009 22:38:38 Bartlomiej Zolnierkiewicz wrote:
> > On Sunday 19 April 2009 18:14:05 Marek Vasut wrote:
> > > On Sunday 22 of March 2009 22:23:10 Marek Vasut wrote:
> > > > > Dne Saturday 16 of August 2008 11:08:03 Russell King - ARM Linux
> > >
> > > napsal(a):
> > > > > > On Wed, Aug 13, 2008 at 10:52:23PM +0200, Marek Vasut wrote:
> > > > > > > This patch adds palmld ide channel support, same as previous
> > > > > > > patch, I think this can be merged since it wont break anything.
> > > > > >
> > > > > > I think this one also needs review by the Linux ATA folk.  Mention
> > > > > > to them that it's part of a patchset for ARM and that you'd prefer
> > > > > > it to be merged into the ARM tree.
> > > > > >
> > > > > > > +static const char drvname[] = "pata_palmld";
> > > > > > > +MODULE_ALIAS("platform: "drvname);
> > > > > >
> > > > > > Have you tried building this as a module?  Also, IIRC, there isn't
> > > > > > supposed to be a space after the colon...
> > > > >
> > > > > Ok, I fixed the issues and CCed linux-ide and the maintainer.
> > > > >
> > > > > Thanks
> > > >
> > > > Hi, Im resending this patch since it was totally ignored last time. It
> > > > still applies correctly. It'd be for the best to push this through
> > > > arm-kernel tree.
> > > >
> > > > Best regards
> > > > Marek Vasut
> > >
> > > It's still being totally ignored on both mailing lists ... why? Thanks
> >
> > I don't know the answer for your question but this patch is not for me.
> >
> > Please take me off cc: list unless you're also going to submit *IDE* driver
> > (sorry, I have no time to review libata patches).  Thanks.
> 
> That's good to know, where should I send it then? Thanks

see Cc: :)

Re: [PATCH 4/6] PalmLD IDE

[Alan Cox]

> > Please take me off cc: list unless you're also going to submit *IDE* driver
> > (sorry, I have no time to review libata patches).  Thanks.
> 
> That's good to know, where should I send it then? Thanks

Send it this way for review.

Alan

Re: [PATCH 4/6] PalmLD IDE

[Marek Vasut]

[-- Attachment #1: Type: text/plain, Size: 44 bytes --]

Here it is, I hope it's not too rotten yet.

[-- Attachment #2: 0004-PalmLD-IDE-support.patch --]
[-- Type: text/x-diff, Size: 5500 bytes --]

From 8881f9cbf66a3050de328f6c020f864ca04c1e9b Mon Sep 17 00:00:00 2001
From: Marek <marek.vasut@gmail.com>
Date: Sat, 16 Aug 2008 16:25:34 +0200
Subject: [PATCH] PalmLD: IDE support
 Support for Palm LifeDrive's internal harddrive

---
 drivers/ata/Kconfig       |    9 +++
 drivers/ata/Makefile      |    1 +
 drivers/ata/pata_palmld.c |  145 +++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 155 insertions(+), 0 deletions(-)
 create mode 100644 drivers/ata/pata_palmld.c

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index ae84949..8e43d11 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -533,6 +533,15 @@ config PATA_OPTIDMA
 
 	  If unsure, say N.
 
+config PATA_PALMLD
+	tristate "Palm LifeDrive PATA support"
+	depends on MACH_PALMLD
+	help
+	  This option enables support for Palm LifeDrive's internal ATA
+	  port via the new ATA layer.
+
+	  If unsure, say N.
+
 config PATA_PCMCIA
 	tristate "PCMCIA PATA support"
 	depends on PCMCIA
diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
index 674965f..2b393c9 100644
--- a/drivers/ata/Makefile
+++ b/drivers/ata/Makefile
@@ -50,6 +50,7 @@ obj-$(CONFIG_PATA_MPC52xx)	+= pata_mpc52xx.o
 obj-$(CONFIG_PATA_MARVELL)	+= pata_marvell.o
 obj-$(CONFIG_PATA_MPIIX)	+= pata_mpiix.o
 obj-$(CONFIG_PATA_OLDPIIX)	+= pata_oldpiix.o
+obj-$(CONFIG_PATA_PALMLD)	+= pata_palmld.o
 obj-$(CONFIG_PATA_PCMCIA)	+= pata_pcmcia.o
 obj-$(CONFIG_PATA_PDC2027X)	+= pata_pdc2027x.o
 obj-$(CONFIG_PATA_PDC_OLD)	+= pata_pdc202xx_old.o
diff --git a/drivers/ata/pata_palmld.c b/drivers/ata/pata_palmld.c
new file mode 100644
index 0000000..f0693f8
--- /dev/null
+++ b/drivers/ata/pata_palmld.c
@@ -0,0 +1,145 @@
+/*
+ * drivers/ata/pata_palmld.c
+ *
+ * Driver for IDE channel in Palm LifeDrive
+ *
+ * Based on research of:
+ *		Alex Osborne <ato@meshy.org>
+ *
+ * Rewrite for mainline:
+ *		Marek Vasut <marek.vasut@gmail.com>
+ *
+ * Rewritten version based on pata_ixp4xx_cf.c:
+ * ixp4xx PATA/Compact Flash driver
+ * Copyright (C) 2006-07 Tower Technologies
+ * Author: Alessandro Zummo <a.zummo@towertech.it>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ */
+
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/libata.h>
+#include <linux/irq.h>
+#include <linux/platform_device.h>
+#include <linux/delay.h>
+#include <linux/gpio.h>
+
+#include <scsi/scsi_host.h>
+#include <mach/palmld.h>
+
+#define DRV_NAME "pata_palmld"
+
+static struct scsi_host_template palmld_sht = {
+	ATA_PIO_SHT(DRV_NAME),
+};
+
+static struct ata_port_operations palmld_port_ops = {
+	.inherits		= &ata_sff_port_ops,
+	.sff_data_xfer		= ata_sff_data_xfer_noirq,
+	.cable_detect		= ata_cable_40wire,
+};
+
+static __devinit int palmld_pata_probe(struct platform_device *pdev)
+{
+	struct ata_host *host;
+	struct ata_port *ap;
+	void __iomem *mem;
+	int ret;
+
+	/* allocate host */
+	host = ata_host_alloc(&pdev->dev, 1);
+	if (!host)
+		return -ENOMEM;
+
+	/* remap drive's physical memory address */
+	mem = devm_ioremap(&pdev->dev, PALMLD_IDE_PHYS, 0x1000);
+	if (!mem)
+		return -ENOMEM;
+
+	/* request and activate power GPIO, IRQ GPIO */
+	ret = gpio_request(GPIO_NR_PALMLD_IDE_PWEN, "HDD PWR");
+	if (ret)
+		goto err1;
+	ret = gpio_direction_output(GPIO_NR_PALMLD_IDE_PWEN, 1);
+	if (ret)
+		goto err2;
+
+	ret = gpio_request(GPIO_NR_PALMLD_IDE_IRQ, "HDD IRQ");
+	if (ret)
+		goto err2;
+	ret = gpio_direction_input(GPIO_NR_PALMLD_IDE_IRQ);
+	if (ret)
+		goto err3;
+
+	/* we'd better wait for drive's ready signal here
+	  (if we knew where it will come from) */
+	msleep(300);
+
+	/* setup the ata port */
+	ap = host->ports[0];
+	ap->ops	= &palmld_port_ops;
+	ap->pio_mask = ATA_PIO4;
+	ap->flags |= ATA_FLAG_MMIO | ATA_FLAG_NO_LEGACY | ATA_FLAG_NO_ATAPI;
+
+	/* memory mapping voodoo */
+	ap->ioaddr.cmd_addr = mem + 0x10;
+	ap->ioaddr.altstatus_addr = mem + 0xe;
+	ap->ioaddr.ctl_addr = mem + 0xe;
+
+	/* start the port */
+	ata_sff_std_ports(&ap->ioaddr);
+
+	/* activate host */
+	return ata_host_activate(host, gpio_to_irq(GPIO_NR_PALMLD_IDE_IRQ),
+					ata_sff_interrupt, IRQF_TRIGGER_RISING,
+					&palmld_sht);
+err3:
+	gpio_free(GPIO_NR_PALMLD_IDE_IRQ);
+err2:
+	gpio_free(GPIO_NR_PALMLD_IDE_PWEN);
+err1:
+	return ret;
+}
+
+static __devexit int palmld_pata_remove(struct platform_device *dev)
+{
+	struct ata_host *host = platform_get_drvdata(dev);
+
+	ata_host_detach(host);
+
+	gpio_free(GPIO_NR_PALMLD_IDE_PWEN);
+	gpio_free(GPIO_NR_PALMLD_IDE_IRQ);
+
+	return 0;
+}
+
+static struct platform_driver palmld_pata_platform_driver = {
+	.driver	 = {
+		.name   = DRV_NAME,
+		.owner  = THIS_MODULE,
+	},
+	.probe		= palmld_pata_probe,
+	.remove		= __devexit_p(palmld_pata_remove),
+};
+
+static int __init palmld_pata_init(void)
+{
+	return platform_driver_register(&palmld_pata_platform_driver);
+}
+
+static void __exit palmld_pata_exit(void)
+{
+	platform_driver_unregister(&palmld_pata_platform_driver);
+}
+
+MODULE_AUTHOR("Marek Vasut <marek.vasut@gmail.com>");
+MODULE_DESCRIPTION("PalmLD PATA driver");
+MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:" DRV_NAME);
+
+module_init(palmld_pata_init);
+module_exit(palmld_pata_exit);
-- 
1.5.6

Re: [PATCH 4/6] PalmLD IDE

[Eric Miao]

On Mon, Mar 23, 2009 at 5:23 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
>> Dne Saturday 16 of August 2008 11:08:03 Russell King - ARM Linux napsal(a):
>> > On Wed, Aug 13, 2008 at 10:52:23PM +0200, Marek Vasut wrote:
>> > > This patch adds palmld ide channel support, same as previous patch, I
>> > > think this can be merged since it wont break anything.
>> >
>> > I think this one also needs review by the Linux ATA folk.  Mention to
>> > them that it's part of a patchset for ARM and that you'd prefer it
>> > to be merged into the ARM tree.
>> >
>> > > +static const char drvname[] = "pata_palmld";
>> > > +MODULE_ALIAS("platform: "drvname);
>> >
>> > Have you tried building this as a module?  Also, IIRC, there isn't
>> > supposed to be a space after the colon...
>>
>> Ok, I fixed the issues and CCed linux-ide and the maintainer.
>>
>> Thanks
>
> Hi, Im resending this patch since it was totally ignored last time. It still
> applies correctly. It'd be for the best to push this through arm-kernel tree.
>

I wonder if this driver can be implemented in a more generic way so
that other boards can be benefited. The only specific things I see are:

1. I/O mapping address space
2. IRQ
3. PowerON

IRQ can be specified by platform_data, and power_on can be implemented
by callbacks in platform_data. I/O mapping should be OK by resources in
platform_device.

So what's else to make this specific to PalmLD?

Re: [PATCH 4/6] PalmLD IDE

[Marek Vasut]

On Tuesday 21 of April 2009 06:02:59 Eric Miao wrote:
> On Mon, Mar 23, 2009 at 5:23 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
> >> Dne Saturday 16 of August 2008 11:08:03 Russell King - ARM Linux 
napsal(a):
> >> > On Wed, Aug 13, 2008 at 10:52:23PM +0200, Marek Vasut wrote:
> >> > > This patch adds palmld ide channel support, same as previous patch,
> >> > > I think this can be merged since it wont break anything.
> >> >
> >> > I think this one also needs review by the Linux ATA folk.  Mention to
> >> > them that it's part of a patchset for ARM and that you'd prefer it
> >> > to be merged into the ARM tree.
> >> >
> >> > > +static const char drvname[] = "pata_palmld";
> >> > > +MODULE_ALIAS("platform: "drvname);
> >> >
> >> > Have you tried building this as a module?  Also, IIRC, there isn't
> >> > supposed to be a space after the colon...
> >>
> >> Ok, I fixed the issues and CCed linux-ide and the maintainer.
> >>
> >> Thanks
> >
> > Hi, Im resending this patch since it was totally ignored last time. It
> > still applies correctly. It'd be for the best to push this through
> > arm-kernel tree.
>
> I wonder if this driver can be implemented in a more generic way so
> that other boards can be benefited. The only specific things I see are:
>
> 1. I/O mapping address space
> 2. IRQ
> 3. PowerON
>
> IRQ can be specified by platform_data, and power_on can be implemented
> by callbacks in platform_data. I/O mapping should be OK by resources in
> platform_device.
>
> So what's else to make this specific to PalmLD?

Will there be anyone who would use that other than palmld then ? I doubt 
anyone has that obscure hardware. That's why I see no point in making this 
generic.

Re: [PATCH 4/6] PalmLD IDE

[Alan Cox]

Questions:

+ ATA_FLAG_NO_ATAPI

Is this a case of the controller cannot handle ATAPI in which case the
flag is correct, or you can't conceive of a user finding a way to add an
ATAPI device (but it would work as usually happens with basic PIO
hardware) in which case it isn't.

+	/* we'd better wait for drive's ready signal here
+	  (if we knew where it will come from) */
+	msleep(300);

Our probe code should already be waiting for ready signals  ?


The only other question is a general architectural one as to whether it
would be better to set up the GPIO etc and create a pata_platform
platform device (possibly tweaking pata_platform flags to allow the
caller to indicate generic pio with mode setting by set features command)

Alan

Re: [PATCH 4/6] PalmLD IDE

[Marek Vasut]

On Tuesday 21 of April 2009 16:27:35 Alan Cox wrote:
> Questions:
>
> + ATA_FLAG_NO_ATAPI
>
> Is this a case of the controller cannot handle ATAPI in which case the
> flag is correct, or you can't conceive of a user finding a way to add an
> ATAPI device (but it would work as usually happens with basic PIO
> hardware) in which case it isn't.

http://www.palm.com/us/support/contact/environment/disassem_inst_Lifedrive.pdf , 
see slide 10 and 15 for yourself, I think noone would want to solder anything 
into that device ;-)

>
> +	/* we'd better wait for drive's ready signal here
> +	  (if we knew where it will come from) */
> +	msleep(300);
>
> Our probe code should already be waiting for ready signals  ?

The drive asserts some GPIO when it becomes ready, dunno which one though so 
we just wait here.
>
>
> The only other question is a general architectural one as to whether it
> would be better to set up the GPIO etc and create a pata_platform
> platform device (possibly tweaking pata_platform flags to allow the
> caller to indicate generic pio with mode setting by set features command)

I already explained this to Eric, there isn't any other obscure hardware I 
think. Or if this is concerning something else, I'll recheck later.
>
> Alan

Thanks
Marek

Re: [PATCH 4/6] PalmLD IDE

[Alan Cox]

> http://www.palm.com/us/support/contact/environment/disassem_inst_Lifedrive.pdf , 
> see slide 10 and 15 for yourself, I think noone would want to solder anything 
> into that device ;-)

Agreed but if the hardware can do it you don't need the flag. Obviously
not very important in this case.

> >
> > +	/* we'd better wait for drive's ready signal here
> > +	  (if we knew where it will come from) */
> > +	msleep(300);
> >
> > Our probe code should already be waiting for ready signals  ?
> 
> The drive asserts some GPIO when it becomes ready, dunno which one though so 
> we just wait here.

Ok so the ATA bus side ready isn't sufficient for your hardware ?

> > The only other question is a general architectural one as to whether it
> > would be better to set up the GPIO etc and create a pata_platform
> > platform device (possibly tweaking pata_platform flags to allow the
> > caller to indicate generic pio with mode setting by set features command)
> 
> I already explained this to Eric, there isn't any other obscure hardware I 
> think. Or if this is concerning something else, I'll recheck later.

Re: [PATCH 4/6] PalmLD IDE

[Marek Vasut]

On Tuesday 21 of April 2009 17:19:33 Alan Cox wrote:
> > http://www.palm.com/us/support/contact/environment/disassem_inst_Lifedriv
> >e.pdf , see slide 10 and 15 for yourself, I think noone would want to
> > solder anything into that device ;-)
>
> Agreed but if the hardware can do it you don't need the flag. Obviously
> not very important in this case.

OK, we can remove that, I'll resend the patch.
>
> > > +	/* we'd better wait for drive's ready signal here
> > > +	  (if we knew where it will come from) */
> > > +	msleep(300);
> > >
> > > Our probe code should already be waiting for ready signals  ?
> >
> > The drive asserts some GPIO when it becomes ready, dunno which one though
> > so we just wait here.
>
> Ok so the ATA bus side ready isn't sufficient for your hardware ?

I can retry without the delay, but I'm quite afraid I ran into problems 
without it. Btw. I rewrote that driver more than half year ago, so I don't 
really recall the details, sorry, I don't want to misinform you here.
>
> > > The only other question is a general architectural one as to whether it
> > > would be better to set up the GPIO etc and create a pata_platform
> > > platform device (possibly tweaking pata_platform flags to allow the
> > > caller to indicate generic pio with mode setting by set features
> > > command)
> >
> > I already explained this to Eric, there isn't any other obscure hardware
> > I think. Or if this is concerning something else, I'll recheck later.

Re: [PATCH 4/6] PalmLD IDE

[Alan Cox]

> > Ok so the ATA bus side ready isn't sufficient for your hardware ?
> 
> I can retry without the delay, but I'm quite afraid I ran into problems 
> without it. Btw. I rewrote that driver more than half year ago, so I don't 
> really recall the details, sorry, I don't want to misinform you here.

No problem... its not as if it slows down anyone elses hardware.

Ok looks fine for merging - via the ARM tree seems best ?

Re: [PATCH 4/6] PalmLD IDE

[Jeff Garzik]

Alan Cox wrote:
>>> Ok so the ATA bus side ready isn't sufficient for your hardware ?
>> I can retry without the delay, but I'm quite afraid I ran into problems 
>> without it. Btw. I rewrote that driver more than half year ago, so I don't 
>> really recall the details, sorry, I don't want to misinform you here.
> 
> No problem... its not as if it slows down anyone elses hardware.
> 
> Ok looks fine for merging - via the ARM tree seems best ?

ARM tree is fine, as long as there's an Acked-by from a libata person -- 
I nominate you, in this case :)

The version posted on 4/20 seemed fine to me (taking into account the 
ensuing thread, of course).

	Jeff