From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [git pull] IDE fixes Date: Wed, 22 Apr 2009 23:41:37 +0200 Message-ID: <200904222341.37846.bzolnier@gmail.com> References: <200904222048.15556.bzolnier@gmail.com> <200904222143.47220.bzolnier@gmail.com> <1240430103.21848.101.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Return-path: Received: from rv-out-0506.google.com ([209.85.198.230]:46383 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752987AbZDVVig (ORCPT ); Wed, 22 Apr 2009 17:38:36 -0400 In-Reply-To: <1240430103.21848.101.camel@localhost> Content-Disposition: inline Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Joe Perches Cc: Linus Torvalds , Andrew Morton , Stephen Rothwell , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org On Wednesday 22 April 2009 21:55:03 Joe Perches wrote: > On Wed, 2009-04-22 at 21:43 +0200, Bartlomiej Zolnierkiewicz wrote: > > IMO we should just remove extra commas and add some whitespaces. > > Your choice. > Ignore, reject, accept, improve, fine by me. > > > I have also more general (process oriented) comment: > > > > All patches have been posted to linux-kernel or linux-ide for review before > > and it is _much_ more efficient to raise issues (including CodingStyle ones) > > during "review phase" instead of during "push to Linus" phase. > > Maybe for you, but I'm an intermittent > and random reader. For everybody involved in the process -- this includes you. I'm not the original author of many patches so I simply cannot be correcting every single issue because: a) it is physically impossible b) it doesn't really educate people Thanks, Bart