From: Matthew Wilcox <matthew@wil.cx>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: rwheeler@redhat.com, snitzer@redhat.com, jeff@garzik.org,
neilb@suse.de, James.Bottomley@hansenpartnership.com,
dgilbert@interlog.com, jens.axboe@oracle.com,
linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 9 of 9] libata: Media rotation rate and form factor heuristics
Date: Fri, 24 Apr 2009 06:30:54 -0600 [thread overview]
Message-ID: <20090424123054.GA1926@parisc-linux.org> (raw)
In-Reply-To: <2fc5b2aa370a8ad47db1.1240551150@sermon.lab.mkp.net>
On Fri, Apr 24, 2009 at 01:32:30AM -0400, Martin K. Petersen wrote:
> This patch delegates setting the queue NONROT flag to SCSI.
>
> It also provides new heuristics for parsing both the form factor and
> media rotation rate ATA IDENFITY words.
>
> The reported ATA version must be 7 or greater and the device must return
> values defined as valid in the standard. Only then are the
> characteristics reported to SCSI via the VPD B1 page.
>
> This seems like a reasonable compromise to me considering that we have
> been shipping several kernel releases that key off the rotation rate bit
> without any version checking whatsoever. With no complaints so far.
>
> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Reviewed-by: Matthew Wilcox <willy@linux.intel.com>
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2009-04-24 12:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-24 5:32 [PATCH 0 of 9] I/O topology patch kit Martin K. Petersen
2009-04-24 5:32 ` [PATCH 1 of 9] block: Expose stacked device queues in sysfs Martin K. Petersen
2009-04-24 5:32 ` [PATCH 2 of 9] block: Export I/O topology for block devices and partitions Martin K. Petersen
2009-04-24 12:14 ` Kay Sievers
2009-04-24 12:54 ` Jeff Garzik
2009-04-24 14:37 ` Carl Henrik Lunde
2009-04-24 14:47 ` Matthew Wilcox
2009-04-24 15:16 ` Martin K. Petersen
2009-04-24 15:00 ` Martin K. Petersen
2009-04-24 14:53 ` Martin K. Petersen
2009-04-24 5:32 ` [PATCH 3 of 9] MD: Use new topology calls to indicate alignment and I/O sizes Martin K. Petersen
2009-04-24 5:32 ` [PATCH 4 of 9] sd: Physical block size and alignment support Martin K. Petersen
2009-04-24 5:32 ` [PATCH 5 of 9] sd: Detect non-rotational devices Martin K. Petersen
2009-04-24 5:32 ` [PATCH 6 of 9] sd: Block limits VPD support Martin K. Petersen
2009-04-24 5:32 ` [PATCH 7 of 9] scsi_debug: Add support for physical block exponent and alignment Martin K. Petersen
2009-04-24 5:32 ` [PATCH 8 of 9] libata: Report disk alignment and physical block size Martin K. Petersen
2009-04-24 5:32 ` [PATCH 9 of 9] libata: Media rotation rate and form factor heuristics Martin K. Petersen
[not found] ` <7ec2d82b188a9e9d4c56.1240551148@sermon.lab.mkp.net>
2009-04-24 6:10 ` [PATCH 7 of 9] scsi_debug: Add support for physical block exponent and alignment Douglas Gilbert
2009-04-24 6:14 ` Martin K. Petersen
[not found] ` <2fc5b2aa370a8ad47db1.1240551150@sermon.lab.mkp.net>
2009-04-24 12:30 ` Matthew Wilcox [this message]
[not found] ` <47f4f448a804a2d24f10.1240551149@sermon.lab.mkp.net>
2009-04-24 12:32 ` [PATCH 8 of 9] libata: Report disk alignment and physical block size Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090424123054.GA1926@parisc-linux.org \
--to=matthew@wil.cx \
--cc=James.Bottomley@hansenpartnership.com \
--cc=dgilbert@interlog.com \
--cc=jeff@garzik.org \
--cc=jens.axboe@oracle.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=neilb@suse.de \
--cc=rwheeler@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).