linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Borislav Petkov <petkovbb@googlemail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
	Tejun Heo <tj@kernel.org>, Jens Axboe <axboe@kernel.dk>
Subject: Re: [RFC PATCH 0/12] ide-atapi remove pc->buf
Date: Sun, 10 May 2009 23:32:24 +0200	[thread overview]
Message-ID: <200905102332.24775.bzolnier@gmail.com> (raw)
In-Reply-To: <1241855134-4984-1-git-send-email-petkovbb@gmail.com>


Hi,

On Saturday 09 May 2009 09:45:20 Borislav Petkov wrote:
> Hi Bart,
> 
> Here's an assortment :) of ide patches touching stuff here and there.
> I've been working on those for a while and initial testing shows no
> problems. Among the changes is a first attempt to remove the 64 byte
> buffer embedded in each packet command sent to an ide drive. Also, some
> ireason handling unification is there along with other minor stuff.

Generally looks good but needs some fixes (see my other mails).

[ also: if you are re-posting any patches please always indicate whether
  (and how) they were changed ]

> This is based ontop of
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git block-unify-sector-and-data_len
> 
> and I'm more than open to suggestions on the logistics of merging those
> (how/when/on top of whose branch/who picks them up/do we want to hit the
> .31 merge window or do more testing?/etc) after being reviewed.
> 
> 
>  drivers/ide/ide-atapi.c        |  145 +++++++++++++++++++++++------------
>  drivers/ide/ide-cd.c           |   69 +++--------------
>  drivers/ide/ide-floppy.c       |   53 ++++++-------
>  drivers/ide/ide-floppy_ioctl.c |   43 ++++++-----
>  drivers/ide/ide-tape.c         |  168 +++++++++++++++++++---------------------
>  include/linux/ide.h            |   18 +----
>  6 files changed, 238 insertions(+), 258 deletions(-)

Good question, how's about:

Once tj/block-unify-sector-and-data_len is in block/for-2.6.31 and your tree
is ready I will pull it into the separate branch.  This branch can be then
pulled into ide/for-next or into new ide/all branch (replacing ide/for-next
in linux-next).

This means that I'll have to synchronize merge window merges with Jens but
this is needed already and shouldn't be a problem.

If somebody [ Tejun/Jens: I'm talking to you :) ] has a better idea how to
handle this please stand-up.

Thanks,
Bart

  parent reply	other threads:[~2009-05-10 21:36 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-09  7:45 [RFC PATCH 0/12] ide-atapi remove pc->buf Borislav Petkov
2009-05-09  7:45 ` [PATCH 01/14] ide-tape: fix potential fs requests bug Borislav Petkov
2009-05-09  8:02   ` Sam Ravnborg
2009-05-09  8:50     ` Borislav Petkov
2009-05-09 10:25       ` Sam Ravnborg
2009-05-09 12:09         ` Borislav Petkov
2009-05-09  7:45 ` [PATCH 02/14] ide-atapi: switch to blk_rq_bytes() on do_request() path Borislav Petkov
2009-05-10 21:32   ` Bartlomiej Zolnierkiewicz
2009-05-09  7:45 ` [PATCH 03/14] ide-atapi: switch to rq->resid_len Borislav Petkov
2009-05-10 21:32   ` Bartlomiej Zolnierkiewicz
2009-05-11  7:23     ` Borislav Petkov
2009-05-11 11:22       ` Bartlomiej Zolnierkiewicz
2009-05-12 14:38   ` Sergei Shtylyov
2009-05-09  7:45 ` [PATCH 04/14] ide-atapi: add a len-parameter to ide_queue_pc_tail Borislav Petkov
2009-05-09  7:45 ` [PATCH 05/14] ide-atapi: add a buffer-arg " Borislav Petkov
2009-05-10 21:32   ` Bartlomiej Zolnierkiewicz
2009-05-09  7:45 ` [PATCH 06/14] ide-floppy/ide_floppy_get_flexible_disk_page: use local buffer Borislav Petkov
2009-05-09  7:45 ` [PATCH 07/14] ide-floppy/ide_floppy_get_sfrp_bit: " Borislav Petkov
2009-05-09  7:45 ` [PATCH 08/14] ide-floppy/ide_floppy_format_unit: " Borislav Petkov
2009-05-09  7:45 ` [PATCH 09/14] ide-atapi: use local sense buffer Borislav Petkov
2009-05-10 21:32   ` Bartlomiej Zolnierkiewicz
2009-05-12  7:17     ` Borislav Petkov
2009-05-09  7:45 ` [PATCH 10/14] ide-tape: fix READ POSITION cmd handling Borislav Petkov
2009-05-09  7:45 ` [PATCH 11/14] ide-tape/ide_tape_get_bsize_from_bdesc: use local buffer Borislav Petkov
2009-05-09  7:45 ` [PATCH 12/14] ide-atapi: remove pc->buf Borislav Petkov
2009-05-09  7:45 ` [PATCH 13/14] ide-cd: use whole request_sense buffer in EH Borislav Petkov
2009-05-09  7:45 ` [PATCH 14/14] ide: unify interrupt reason checking Borislav Petkov
2009-05-10 21:39   ` Bartlomiej Zolnierkiewicz
2009-05-10 21:32 ` Bartlomiej Zolnierkiewicz [this message]
2009-05-10 23:30   ` [RFC PATCH 0/12] ide-atapi remove pc->buf Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200905102332.24775.bzolnier@gmail.com \
    --to=bzolnier@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=petkovbb@googlemail.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).