From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
Sergei Shtylyov <sshtylyov@ru.mvista.com>
Subject: Re: [PATCH 0/6] drivers/ide Convert printk(KERN_<foo> to pr_<foo>(
Date: Mon, 18 May 2009 17:48:40 +0200 [thread overview]
Message-ID: <200905181748.41172.bzolnier@gmail.com> (raw)
In-Reply-To: <1242661288.1572.82.camel@Joe-Laptop.home>
On Monday 18 May 2009 17:41:28 Joe Perches wrote:
> On Mon, 2009-05-18 at 16:12 +0200, Bartlomiej Zolnierkiewicz wrote:
> > On Monday 18 May 2009 04:21:08 Joe Perches wrote:
> > > Mostly mechanical conversion of printk's
> > Hmm.. less mechanical conversion using also dev_*() macros where suitable
> > would be much better...
> > How's about fixing pr_devel() which currently doesn't seem to be used
> > by anything inside kernel to not depend on DEBUG in separate pre-patch
> > and then using it instead of pr_debug()?
>
> How about deferring the "printk(KERN_DEBUG" to something else
> and doing the mechanical conversion to core as a first pass,
> followed by core pr_<foo> to dev_<foo> where appropriate
> as a second pass?
Fine with me.
> What do you think is appropriate for pr_<foo> to dev_<foo>
> conversions?
printk()s using drive->name or hwif->name
Thanks,
Bart
next prev parent reply other threads:[~2009-05-18 15:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1242609803.git.joe@perches.com>
2009-05-18 2:21 ` [PATCH 1/6] drivers/ide: Convert printk(KERN_DEBUG to pr_debug( Joe Perches
2009-05-18 9:34 ` Sergei Shtylyov
2009-05-18 2:21 ` [PATCH 2/6] drivers/ide: Convert printk(KERN_INFO to pr_info( Joe Perches
2009-05-18 2:31 ` Joe Perches
2009-05-18 2:21 ` [PATCH 3/6] drivers/ide: Convert printk(KERN_ERR to pr_err( Joe Perches
2009-05-18 2:21 ` [PATCH 4/6] drivers/ide: Convert printk(KERN_WARNING to pr_warning( Joe Perches
2009-05-18 2:21 ` [PATCH 5/6] drivers/ide: Convert printk(KERN_CONT to pr_cont( Joe Perches
2009-05-18 2:21 ` [PATCH 6/6] drivers/ide: Convert printk(KERN_NOTICE to pr_notice( Joe Perches
2009-05-18 10:11 ` Sergei Shtylyov
2009-05-18 13:22 ` Krzysztof Halasa
2009-05-18 13:38 ` Sergei Shtylyov
2009-05-18 13:50 ` Bartlomiej Zolnierkiewicz
2009-05-18 17:18 ` Krzysztof Halasa
2009-05-18 18:55 ` Alan Cox
2009-05-18 13:32 ` Joe Perches
2009-05-18 14:12 ` [PATCH 0/6] drivers/ide Convert printk(KERN_<foo> to pr_<foo>( Bartlomiej Zolnierkiewicz
2009-05-18 15:41 ` Joe Perches
2009-05-18 15:48 ` Bartlomiej Zolnierkiewicz [this message]
2009-05-18 15:56 ` James Bottomley
2009-05-18 20:59 ` Joe Perches
2009-05-18 21:15 ` James Bottomley
2009-05-18 21:21 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905181748.41172.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=joe@perches.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).