From: Mike Snitzer <snitzer@redhat.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: rwheeler@redhat.com, jeff@garzik.org, neilb@suse.de,
James.Bottomley@hansenpartnership.com, jens.axboe@oracle.com,
linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
agk@redhat.com
Subject: Re: [PATCH 03/13] block: Move queue limits to an embedded struct
Date: Mon, 18 May 2009 14:50:08 -0400 [thread overview]
Message-ID: <20090518185007.GA839@redhat.com> (raw)
In-Reply-To: <1242362435-11953-4-git-send-email-martin.petersen@oracle.com>
On Fri, May 15 2009 at 12:40am -0400,
Martin K. Petersen <martin.petersen@oracle.com> wrote:
> From: Martin K. Petersen <martin.petersen@oracle.com>
>
> To accommodate stacking drivers that do not have an associated request
> queue we're moving the limits to a separate, embedded structure.
Given DM motivated this change, any reason you held off including the
associated DM changes (in a separate patch in the series)? Your initial
DM patch looked reasonable.
On some level leaving that patch out of the series prevents reviewers
the opportunity to really see why a separate 'queue_limits' structure is
even needed. The follow-up question being: is the topology
infrastructure adequately equipped to support DM? I think so
but having others' review would be nice.
Are you looking for such DM changes to be submitted through Alasdair's
tree _after_ your changes go upstream through Jens' tree?
Regards,
Mike
next prev parent reply other threads:[~2009-05-18 18:59 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-15 4:40 I/O Topology v3 Martin K. Petersen
2009-05-15 4:40 ` [PATCH 01/13] block: Do away with the notion of hardsect_size Martin K. Petersen
2009-05-15 4:40 ` [PATCH 02/13] block: Use accessor functions for queue limits Martin K. Petersen
2009-05-31 15:51 ` Bartlomiej Zolnierkiewicz
2009-06-01 5:08 ` Martin K. Petersen
2009-06-01 5:15 ` Jens Axboe
2009-06-01 5:28 ` Martin K. Petersen
2009-05-15 4:40 ` [PATCH 03/13] block: Move queue limits to an embedded struct Martin K. Petersen
2009-05-18 18:50 ` Mike Snitzer [this message]
2009-05-18 18:52 ` Mike Snitzer
2009-05-19 16:46 ` Martin K. Petersen
2009-05-15 4:40 ` [PATCH 04/13] block: Expose stacked device queues in sysfs Martin K. Petersen
2009-05-15 4:40 ` [PATCH 05/13] block: Export I/O topology for block devices and partitions Martin K. Petersen
2009-05-18 17:57 ` Jens Axboe
2009-05-18 18:12 ` Mike Snitzer
2009-05-19 16:41 ` Martin K. Petersen
2009-05-19 18:15 ` Jens Axboe
2009-05-20 21:19 ` Martin K. Petersen
2009-05-22 7:30 ` Jens Axboe
2009-05-22 13:34 ` Martin K. Petersen
2009-05-22 18:16 ` Jens Axboe
2009-05-15 4:40 ` [PATCH 06/13] MD: Use new topology calls to indicate alignment and I/O sizes Martin K. Petersen
2009-05-15 4:40 ` [PATCH 07/13] block: Deprecate blk_queue_stack_limits Martin K. Petersen
2009-05-15 4:40 ` [PATCH 08/13] sd: Physical block size and alignment support Martin K. Petersen
2009-05-15 4:40 ` [PATCH 09/13] sd: Detect non-rotational devices Martin K. Petersen
2009-05-15 4:40 ` [PATCH 10/13] sd: Block limits VPD support Martin K. Petersen
2009-05-15 4:40 ` [PATCH 11/13] scsi_debug: Add support for physical block exponent and alignment Martin K. Petersen
2009-05-19 15:11 ` Douglas Gilbert
2009-05-15 4:40 ` [PATCH 12/13] libata: Report disk alignment and physical block size Martin K. Petersen
2009-05-15 18:17 ` Jeff Garzik
2009-05-15 4:40 ` [PATCH 13/13] libata: Media rotation rate and form factor heuristics Martin K. Petersen
2009-05-15 18:17 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090518185007.GA839@redhat.com \
--to=snitzer@redhat.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=agk@redhat.com \
--cc=jeff@garzik.org \
--cc=jens.axboe@oracle.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=neilb@suse.de \
--cc=rwheeler@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).