linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: linux-ide@vger.kernel.org
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
	"Andries E. Brouwer" <Andries.Brouwer@cwi.nl>,
	linux-kernel@vger.kernel.org,
	Robert Hancock <hancockrwd@gmail.com>,
	Al Viro <viro@zeniv.linux.org.uk>, Frans Pop <elendil@planet.nl>
Subject: [PATCH 0/4] partitions/ide: improve Host Protected Area handling
Date: Sun, 31 May 2009 16:39:11 +0200	[thread overview]
Message-ID: <20090531143911.7164.26834.sendpatchset@localhost.localdomain> (raw)


Hi,

Since from the perspective of most users of recent systems, disabling
Host Protected Area (HPA) can break vendor RAID formats, GPT partitions
and risks corrupting firmware or overwriting vendor system recovery tools
this patchset makes the IDE subsystem preserve HPA by default.

Unfortunately the original (kernels < 2.6.30) behavior (unconditionally
disabling HPA and using full disk capacity) was introduced at the time
when the main use of HPA was to make the drive look small enough for the
BIOS to allow the system to boot with large capacity drives.

Thus to allow the maximum compatibility with the existing setups (using
HPA and partitioned with HPA disabled) we automatically disable HPA if
any partitions overlapping HPA are detected.  Additionally HPA can also
be disabled using the "nohpa" module parameter (i.e. "ide_core.nohpa=0.0"
to disable HPA on /dev/hda).

I tested it with artificially created HPA (using 'hdparm -N p', kudos to
Mark Lord for that) and it worked as expected:

	hda: Host Protected Area detected.
		current capacity is 117210000 sectors (60011 MB)
		native  capacity is 117210240 sectors (60011 MB)
	hda: 117210000 sectors (60011 MB) w/7884KiB Cache, CHS=16383/255/63
	hda: cache flushes supported
	 hda: hda1 hda2 hda3 hda4 < hda5 hda6 >
	hda: p6 size 44869482 exceeds device capacity, enabling native capacity
	hda: detected capacity change from 60011520000 to 60011642880


Thanks to Robert Hancock, Frans Pop and Andries E. Brouwer for input/ideas on
previous (now obsoleted) HPA patches.

[ Robert, it seems possible to use ->set_capacity block device method also in
  libata to improving HPA handling and fix previously discussed compatibility
  issue. ]


patches:
 #01: warn about the partition exceeding device capacity in rescan_partions()

 #02: add ->set_capacity method to struct block_device_operations and use it
      in rescan_partitions() to enable native device capacity if any partition
      exceeding device capacity is detected

 #03: implement ->set_capacity method in ide-gd device driver to handle HPA

 #04: change the original kernel behavior and preserve HPA by default

 For easier testing the combined patch against 2.6.30-rc7 is available here:

	http://www.kernel.org/pub/linux/kernel/people/bart/hpa-2.6.30-rc7.patch


diffstat:
 Documentation/ide/ide.txt           |    2 +
 Documentation/kernel-parameters.txt |    7 +-----
 drivers/ide/ide-disk.c              |   22 ++++++++++++++++++
 drivers/ide/ide-gd.c                |   14 ++++++++++++
 drivers/ide/ide.c                   |   10 ++++++++
 fs/partitions/check.c               |   42 +++++++++++++++++++++++++++---------
 include/linux/blkdev.h              |    2 +
 include/linux/genhd.h               |    1 
 include/linux/ide.h                 |    6 +++--
 9 files changed, 88 insertions(+), 18 deletions(-)

             reply	other threads:[~2009-05-31 14:33 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-31 14:39 Bartlomiej Zolnierkiewicz [this message]
2009-05-31 14:39 ` [PATCH 1/4] partitions: warn about the partition exceeding device capacity Bartlomiej Zolnierkiewicz
2009-05-31 14:39 ` [PATCH 2/4] partitions: add ->set_capacity block device method Bartlomiej Zolnierkiewicz
2009-06-06  8:42   ` Al Viro
2009-05-31 14:39 ` [PATCH 3/4] ide-gd: implement block device ->set_capacity method Bartlomiej Zolnierkiewicz
2009-06-01 21:32   ` Bartlomiej Zolnierkiewicz
2009-06-02 18:55     ` Sergei Shtylyov
2009-06-05 18:38       ` Bartlomiej Zolnierkiewicz
2009-05-31 14:39 ` [PATCH 4/4] ide: preserve Host Protected Area by default Bartlomiej Zolnierkiewicz
2009-06-01 21:33   ` Bartlomiej Zolnierkiewicz
2009-06-02 19:12     ` Sergei Shtylyov
2009-05-31 15:24 ` [PATCH 0/4] partitions/ide: improve Host Protected Area handling Andries E. Brouwer
2009-05-31 15:34   ` Bartlomiej Zolnierkiewicz
2009-06-01 13:02     ` Greg Freemyer
2009-05-31 16:36 ` Alan Cox
2009-05-31 20:04 ` Frans Pop
2009-05-31 22:50   ` Andries E. Brouwer
2009-06-01 12:59 ` Greg Freemyer
2009-06-01 13:06   ` Alan Cox
2009-06-01 22:00     ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090531143911.7164.26834.sendpatchset@localhost.localdomain \
    --to=bzolnier@gmail.com \
    --cc=Andries.Brouwer@cwi.nl \
    --cc=elendil@planet.nl \
    --cc=hancockrwd@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).