From: Frans Pop <elendil@planet.nl>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org,
"Andries E. Brouwer" <Andries.Brouwer@cwi.nl>,
linux-kernel@vger.kernel.org,
Robert Hancock <hancockrwd@gmail.com>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH 0/4] partitions/ide: improve Host Protected Area handling
Date: Sun, 31 May 2009 22:04:11 +0200 [thread overview]
Message-ID: <200905312204.12549.elendil@planet.nl> (raw)
In-Reply-To: <20090531143911.7164.26834.sendpatchset@localhost.localdomain>
On Sunday 31 May 2009, Bartlomiej Zolnierkiewicz wrote:
> Since from the perspective of most users of recent systems, disabling
> Host Protected Area (HPA) can break vendor RAID formats, GPT partitions
> and risks corrupting firmware or overwriting vendor system recovery
> tools this patchset makes the IDE subsystem preserve HPA by default.
Kudos! I have to leave a real review of the patches to others more
qualified than me, but where the previous patch set raised all sorts of
questions for me, this just looks logical.
I conclude the following from reading the patches:
- a HPA is always at the end of a disk, correct?
- the only case where a user should notice a change after switching
to 2.6.30 is if he has a partition that starts on or after the
start of the HPA: such a partition will be ignored (with warning
in dmesg); I guess that is reasonable as at least it will prevent
"broken" partitions and is probably relatively uncommon.
Thanks for your continued work on this Bart.
Cheers,
FJP
next prev parent reply other threads:[~2009-05-31 20:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-31 14:39 [PATCH 0/4] partitions/ide: improve Host Protected Area handling Bartlomiej Zolnierkiewicz
2009-05-31 14:39 ` [PATCH 1/4] partitions: warn about the partition exceeding device capacity Bartlomiej Zolnierkiewicz
2009-05-31 14:39 ` [PATCH 2/4] partitions: add ->set_capacity block device method Bartlomiej Zolnierkiewicz
2009-06-06 8:42 ` Al Viro
2009-05-31 14:39 ` [PATCH 3/4] ide-gd: implement block device ->set_capacity method Bartlomiej Zolnierkiewicz
2009-06-01 21:32 ` Bartlomiej Zolnierkiewicz
2009-06-02 18:55 ` Sergei Shtylyov
2009-06-05 18:38 ` Bartlomiej Zolnierkiewicz
2009-05-31 14:39 ` [PATCH 4/4] ide: preserve Host Protected Area by default Bartlomiej Zolnierkiewicz
2009-06-01 21:33 ` Bartlomiej Zolnierkiewicz
2009-06-02 19:12 ` Sergei Shtylyov
2009-05-31 15:24 ` [PATCH 0/4] partitions/ide: improve Host Protected Area handling Andries E. Brouwer
2009-05-31 15:34 ` Bartlomiej Zolnierkiewicz
2009-06-01 13:02 ` Greg Freemyer
2009-05-31 16:36 ` Alan Cox
2009-05-31 20:04 ` Frans Pop [this message]
2009-05-31 22:50 ` Andries E. Brouwer
2009-06-01 12:59 ` Greg Freemyer
2009-06-01 13:06 ` Alan Cox
2009-06-01 22:00 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905312204.12549.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=Andries.Brouwer@cwi.nl \
--cc=bzolnier@gmail.com \
--cc=hancockrwd@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).