From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 4/4] ide: preserve Host Protected Area by default Date: Mon, 1 Jun 2009 23:33:23 +0200 Message-ID: <200906012333.29159.bzolnier@gmail.com> References: <20090531143911.7164.26834.sendpatchset@localhost.localdomain> <20090531143939.7164.82399.sendpatchset@localhost.localdomain> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ew0-f176.google.com ([209.85.219.176]:61789 "EHLO mail-ew0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759151AbZFAVz7 (ORCPT ); Mon, 1 Jun 2009 17:55:59 -0400 In-Reply-To: <20090531143939.7164.82399.sendpatchset@localhost.localdomain> Content-Disposition: inline Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: linux-ide@vger.kernel.org Cc: "Andries E. Brouwer" , linux-kernel@vger.kernel.org, Robert Hancock , Al Viro , Frans Pop On Sunday 31 May 2009 16:39:39 Bartlomiej Zolnierkiewicz wrote: > From: Bartlomiej Zolnierkiewicz > Subject: [PATCH] ide: preserve Host Protected Area by default > > From the perspective of most users of recent systems, disabling Host > Protected Area (HPA) can break vendor RAID formats, GPT partitions and > risks corrupting firmware or overwriting vendor system recovery tools. > > Unfortunately the original (kernels < 2.6.30) behavior (unconditionally > disabling HPA and using full disk capacity) was introduced at the time > when the main use of HPA was to make the drive look small enough for the > BIOS to allow the system to boot with large capacity drives. > > Thus to allow the maximum compatibility with the existing setups (using > HPA and partitioned with HPA disabled) we automatically disable HPA if > any partitions overlapping HPA are detected. Additionally HPA can also > be disabled using the "nohpa" module parameter (i.e. "ide_core.nohpa=0.0" > to disable HPA on /dev/hda). > > While at it: > - remove stale "idebus=" entry from Documentation/kernel-parameters.txt > > Cc: Robert Hancock > Cc: Frans Pop > Cc: "Andries E. Brouwer" > Cc: Al Viro > [patch description was based on input from Alan Cox and Frans Pop] > Signed-off-by: Bartlomiej Zolnierkiewicz v2 interdiff v2: Fix ->resume HPA support. --- ide-disk.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff -u b/drivers/ide/ide-disk.c b/drivers/ide/ide-disk.c --- b/drivers/ide/ide-disk.c +++ b/drivers/ide/ide-disk.c @@ -433,8 +433,11 @@ goto out; set = ide_disk_hpa_set_capacity(drive, set, lba48); - if (set) + if (set) { + /* needed for ->resume to disable HPA */ + drive->dev_flags |= IDE_DFLAG_NOHPA; return set; + } out: return drive->capacity64; }