From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/3] pdc202xx_old: use ide_dma_test_irq()
Date: Sun, 7 Jun 2009 14:55:46 +0200 [thread overview]
Message-ID: <200906071455.46396.bzolnier@gmail.com> (raw)
In-Reply-To: <4A28326E.2010406@ru.mvista.com>
On Thursday 04 June 2009 22:45:34 Sergei Shtylyov wrote:
> Hello, I wrote:
>
> > The driver's dma_test_irq() method, although tests some chip specific interrupt
> > bits, finally always relies on the SFF-8038i standard interrupt bit. I see no
> > point in testing the bits that are not trusted anyway -- the driver should be
> > fully able to use the standard method implemetation, ide_dma_test_irq().
> >
> > With this change 'pdc202xx_dma_ops' finally becomes identical to 'sff_dma_ops',
> > and we can get rid of it...
> >
> > ---
> > The patch is against the ide-2.6.git 'for-next' branch, atop of 2 patches
> > sent recently...
> >
> > I'll probably revive the remomed code as a part of the test_irq() method...
> >
> > Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> >
>
> Oops, put signoff under tearline again. Bart, hopefully you'll be able
> to handle that... :-)
I somehow managed to fix it... ;)
applied 1-3
prev parent reply other threads:[~2009-06-07 13:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200906042329.13000.sshtylyov@ru.mvista.com>
2009-06-04 20:45 ` [PATCH 1/3] pdc202xx_old: use ide_dma_test_irq() Sergei Shtylyov
2009-06-07 12:55 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906071455.46396.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).