* Re: [PATCH 1/3] pdc202xx_old: use ide_dma_test_irq() [not found] <200906042329.13000.sshtylyov@ru.mvista.com> @ 2009-06-04 20:45 ` Sergei Shtylyov 2009-06-07 12:55 ` Bartlomiej Zolnierkiewicz 0 siblings, 1 reply; 2+ messages in thread From: Sergei Shtylyov @ 2009-06-04 20:45 UTC (permalink / raw) To: bzolnier; +Cc: linux-ide Hello, I wrote: > The driver's dma_test_irq() method, although tests some chip specific interrupt > bits, finally always relies on the SFF-8038i standard interrupt bit. I see no > point in testing the bits that are not trusted anyway -- the driver should be > fully able to use the standard method implemetation, ide_dma_test_irq(). > > With this change 'pdc202xx_dma_ops' finally becomes identical to 'sff_dma_ops', > and we can get rid of it... > > --- > The patch is against the ide-2.6.git 'for-next' branch, atop of 2 patches > sent recently... > > I'll probably revive the remomed code as a part of the test_irq() method... > > Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> > Oops, put signoff under tearline again. Bart, hopefully you'll be able to handle that... :-) WBR, Sergei ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/3] pdc202xx_old: use ide_dma_test_irq() 2009-06-04 20:45 ` [PATCH 1/3] pdc202xx_old: use ide_dma_test_irq() Sergei Shtylyov @ 2009-06-07 12:55 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 2+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2009-06-07 12:55 UTC (permalink / raw) To: Sergei Shtylyov; +Cc: linux-ide On Thursday 04 June 2009 22:45:34 Sergei Shtylyov wrote: > Hello, I wrote: > > > The driver's dma_test_irq() method, although tests some chip specific interrupt > > bits, finally always relies on the SFF-8038i standard interrupt bit. I see no > > point in testing the bits that are not trusted anyway -- the driver should be > > fully able to use the standard method implemetation, ide_dma_test_irq(). > > > > With this change 'pdc202xx_dma_ops' finally becomes identical to 'sff_dma_ops', > > and we can get rid of it... > > > > --- > > The patch is against the ide-2.6.git 'for-next' branch, atop of 2 patches > > sent recently... > > > > I'll probably revive the remomed code as a part of the test_irq() method... > > > > Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> > > > > Oops, put signoff under tearline again. Bart, hopefully you'll be able > to handle that... :-) I somehow managed to fix it... ;) applied 1-3 ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-06-07 13:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200906042329.13000.sshtylyov@ru.mvista.com>
2009-06-04 20:45 ` [PATCH 1/3] pdc202xx_old: use ide_dma_test_irq() Sergei Shtylyov
2009-06-07 12:55 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).