From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 0/2] ide-tape: fix flags Date: Sun, 7 Jun 2009 15:04:13 +0200 Message-ID: <200906071504.13725.bzolnier@gmail.com> References: <1243926308-32385-1-git-send-email-petkovbb@gmail.com> <200906052034.06668.bzolnier@gmail.com> <20090606175836.GA12865@liondog.tnic> Mime-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-bw0-f213.google.com ([209.85.218.213]:55405 "EHLO mail-bw0-f213.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752413AbZFGNoz (ORCPT ); Sun, 7 Jun 2009 09:44:55 -0400 In-Reply-To: <20090606175836.GA12865@liondog.tnic> Content-Disposition: inline Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Borislav Petkov Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Slaby [ added Jiri to cc: ] On Saturday 06 June 2009 19:58:36 Borislav Petkov wrote: > On Fri, Jun 05, 2009 at 08:34:06PM +0200, Bartlomiej Zolnierkiewicz wrote: > > On Tuesday 02 June 2009 09:05:06 Borislav Petkov wrote: > > > Hi Bart, > > > > > > those fix a stupid flags misuse that got spotted by Jiri Slaby. Please > > > pay special attention to the first patch. FWIW, those can go as hot > > > fixes right away and we might catch 30-rc8 since it's not out yet. > > > > The problem is that patches seem to be against ide-2.6.git/for-next... > > Sh*t, this is hitting the broken buffer allocation that Tejun removed > (I'm getting the same OOM-kill as the one Tejun's mentioning here > http://marc.info/?l=linux-ide&m=124191711928890) so even with those > patches, ide-tape is still broken. > > I'm guessing backport all of Tejun's ide-tape cleanup stuff after Linus > pulls them into 31-rc1? Seems so, though it may be too much work for too little gain (we still have other open ide-tape issues like DMA related one). In the meantime I applied your patches to for-next..