[PATCH 2.6.29] ide-tape: remove back-to-back REQUEST_SENSE detection

[PATCH 2.6.29] ide-tape: remove back-to-back REQUEST_SENSE detection

[Borislav Petkov]

Hi,

please include, commit id upstream:

1e75540ec5202cae63cd238c86bd880e3d496546

---
From: Tejun Heo <tj@kernel.org>
Date: Wed, 27 May 2009 09:12:05 +0200
Subject: [PATCH] ide-tape: remove back-to-back REQUEST_SENSE detection

Impact: fix an oops which always triggers

ide_tape_issue_pc() assumed drive->pc isn't NULL on invocation when
checking for back-to-back request sense issues but drive->pc can be
NULL and even when it's not NULL, it's not safe to dereference it once
the previous command is complete because pc could have been freed or
was on stack.  Kill back-to-back REQUEST_SENSE detection.

Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Borislav Petkov <petkovbb@gmail.com>
---
 drivers/ide/ide-tape.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index 4e6181c..af7860c 100644
--- a/drivers/ide/ide-tape.c
+++ b/drivers/ide/ide-tape.c
@@ -654,12 +654,6 @@ static ide_startstop_t idetape_issue_pc(ide_drive_t *drive,
 {
 	idetape_tape_t *tape = drive->driver_data;
 
-	if (drive->pc->c[0] == REQUEST_SENSE &&
-	    pc->c[0] == REQUEST_SENSE) {
-		printk(KERN_ERR "ide-tape: possible ide-tape.c bug - "
-			"Two request sense in serial were issued\n");
-	}
-
 	if (tape->failed_pc == NULL && pc->c[0] != REQUEST_SENSE)
 		tape->failed_pc = pc;
 
-- 
1.6.3.1

-- 
Regards/Gruss,
    Boris.

Re: [PATCH 2.6.29] ide-tape: remove back-to-back REQUEST_SENSE detection

[Bartlomiej Zolnierkiewicz]

On Wednesday 27 May 2009 09:20:04 Borislav Petkov wrote:
> Hi,
> 
> please include, commit id upstream:
> 
> 1e75540ec5202cae63cd238c86bd880e3d496546

This is for-next branch..

The right commit is 36999a5af1b6c5379e59f0ddf434db08d03c19e4 (because it
was later cherry picked into for-linus) and has my S-o-B line.

Re: [PATCH 2.6.29] ide-tape: remove back-to-back REQUEST_SENSE detection

[Borislav Petkov]

On Wed, May 27, 2009 at 09:40:40AM +0200, Bartlomiej Zolnierkiewicz wrote:
> On Wednesday 27 May 2009 09:20:04 Borislav Petkov wrote:
> > Hi,
> > 
> > please include, commit id upstream:
> > 
> > 1e75540ec5202cae63cd238c86bd880e3d496546
> 
> This is for-next branch..
> 
> The right commit is 36999a5af1b6c5379e59f0ddf434db08d03c19e4 (because it
> was later cherry picked into for-linus) and has my S-o-B line.

Thanks, had the wrong commit id noted here.

-- 
Regards/Gruss,
    Boris.

Re: [stable] [PATCH 2.6.29] ide-tape: remove back-to-back REQUEST_SENSE detection

[Greg KH]

On Wed, May 27, 2009 at 10:03:45AM +0200, Borislav Petkov wrote:
> On Wed, May 27, 2009 at 09:40:40AM +0200, Bartlomiej Zolnierkiewicz wrote:
> > On Wednesday 27 May 2009 09:20:04 Borislav Petkov wrote:
> > > Hi,
> > > 
> > > please include, commit id upstream:
> > > 
> > > 1e75540ec5202cae63cd238c86bd880e3d496546
> > 
> > This is for-next branch..
> > 
> > The right commit is 36999a5af1b6c5379e59f0ddf434db08d03c19e4 (because it
> > was later cherry picked into for-linus) and has my S-o-B line.
> 
> Thanks, had the wrong commit id noted here.

Now queued up, thanks.

greg k-h