From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] sgiioc4: coding style cleanup
Date: Mon, 15 Jun 2009 18:32:51 +0200 [thread overview]
Message-ID: <200906151832.51733.bzolnier@gmail.com> (raw)
In-Reply-To: <200906112154.40247.sshtylyov@ru.mvista.com>
On Thursday 11 June 2009 19:54:40 Sergei Shtylyov wrote:
> Fix several errors and warnings given by checkpatch.pl:
>
> - space between the asterisk and parameter name;
>
> - inconsistent spacing between operator and operands;
>
> - space between *sizeof* and open parenthesis;
>
> - #include <asm/io.h> instead of #include <linux/io.h>
>
> - use of *typedef* instead of a structure tag;
>
> - line over 80 characters.
>
> In addition to these changes, also do the following:
>
> - indent with tabs instead of spaces;
>
> - put the function's result type and name/parameters on the same line;
>
> - join back the needlessly broken lines;
>
> - get rid of needless type cast in sgiioc4_checkirq();
>
> - remove space between the type cast and the variable name;
>
> - remove commented out field initializer;
>
> - uppercase the acronyms, lowercase the normal words in the comments;
>
> - fix up the multi-line comment style...
>
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
applied
next prev parent reply other threads:[~2009-06-15 16:49 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-13 22:01 [PATCH] (pata-2.6 fix queue) sl82c105: rework PIO support Sergei Shtylyov
2007-02-14 19:48 ` Bartlomiej Zolnierkiewicz
2007-03-28 17:47 ` [PATCH pata-2.6] sl82c105: rework PIO support (take 2) Sergei Shtylyov
2007-03-28 18:06 ` Sergei Shtylyov
2007-04-04 19:33 ` Bartlomiej Zolnierkiewicz
2007-04-04 19:42 ` Sergei Shtylyov
2007-04-04 19:24 ` Bartlomiej Zolnierkiewicz
2009-06-08 17:46 ` [PATCH] sl82c105: add printk() logging facility Sergei Shtylyov
2009-06-08 19:56 ` Bartlomiej Zolnierkiewicz
2009-06-10 18:44 ` [PATCH 1/9] cmd64x: implement clear_irq() method Sergei Shtylyov
2009-06-12 16:16 ` Bartlomiej Zolnierkiewicz
2009-06-12 18:39 ` Sergei Shtylyov
2009-06-12 19:01 ` Bartlomiej Zolnierkiewicz
2009-06-12 19:13 ` Sergei Shtylyov
2009-06-12 19:38 ` Bartlomiej Zolnierkiewicz
2009-06-12 20:04 ` Sergei Shtylyov
2009-06-10 18:47 ` [PATCH 2/9] ide: call clear_irq() method in ide_timer_expiry() Sergei Shtylyov
2009-06-10 18:50 ` [PATCH 3/9] ide: move IRQ clearing from ack_intr() method to clear_irq() method Sergei Shtylyov
2009-06-12 16:18 ` Bartlomiej Zolnierkiewicz
2009-06-12 18:24 ` Sergei Shtylyov
2009-06-12 18:48 ` Bartlomiej Zolnierkiewicz
2009-06-12 19:07 ` Sergei Shtylyov
2009-06-12 19:17 ` Sergei Shtylyov
2009-06-12 19:25 ` Bartlomiej Zolnierkiewicz
2009-06-10 18:51 ` [PATCH 4/9] ide: move ack_intr() method into 'struct ide_port_ops' Sergei Shtylyov
2009-06-12 16:19 ` Bartlomiej Zolnierkiewicz
2009-06-12 19:24 ` Sergei Shtylyov
2009-06-10 18:58 ` [PATCH 5/9] cmd640: implement test_irq() method Sergei Shtylyov
2009-06-10 18:59 ` [PATCH 6/9] cmd64x: " Sergei Shtylyov
2009-06-10 19:01 ` [PATCH 7/9] pdc202xx_old: " Sergei Shtylyov
2009-06-12 16:20 ` Bartlomiej Zolnierkiewicz
2009-06-12 19:31 ` Sergei Shtylyov
2009-06-10 19:05 ` [PATCH 8/9] siimage: " Sergei Shtylyov
2009-06-10 20:47 ` Sergei Shtylyov
2009-06-11 18:39 ` [PATCH 7.5/9] siimage: use ide_dma_test_irq() Sergei Shtylyov
2009-06-12 16:22 ` Bartlomiej Zolnierkiewicz
2009-06-12 19:32 ` Sergei Shtylyov
2009-06-11 18:41 ` [PATCH 8/9] siimage: implement test_irq() method Sergei Shtylyov
2009-06-13 13:30 ` [PATCH 3/10] siimage: use ide_dma_test_irq() (take 2) Sergei Shtylyov
2009-06-10 19:06 ` [PATCH 9/9] sl82c105: implement test_irq() method Sergei Shtylyov
2009-06-11 17:54 ` [PATCH] sgiioc4: coding style cleanup Sergei Shtylyov
2009-06-15 16:32 ` Bartlomiej Zolnierkiewicz [this message]
2009-06-13 13:29 ` [PATCH 1/10] ide: call clear_irq() method in ide_timer_expiry() Sergei Shtylyov
2009-06-15 16:41 ` Bartlomiej Zolnierkiewicz
2009-06-13 13:30 ` [PATCH 2/10] cmd64x: implement clear_irq() method (take 2) Sergei Shtylyov
2009-06-13 13:31 ` [PATCH 4/10] ide: move IRQ clearing from ack_intr() method to " Sergei Shtylyov
2009-06-13 13:31 ` [PATCH 5/10] ide: move ack_intr() method into 'struct ide_port_ops' " Sergei Shtylyov
2009-06-13 16:15 ` Finn Thain
2009-06-14 3:37 ` Finn Thain
2009-06-13 13:34 ` [PATCH 6/10] cmd640: implement test_irq() method Sergei Shtylyov
2009-06-13 13:35 ` [PATCH 7/10] cmd64x: " Sergei Shtylyov
2009-06-13 13:38 ` [PATCH 8/10] pdc202xx_old: implement test_irq() method (take 2) Sergei Shtylyov
2010-04-12 21:07 ` Sergei Shtylyov
2009-06-13 13:38 ` [PATCH 9/10] siimage: implement test_irq() method Sergei Shtylyov
2009-06-13 13:39 ` [PATCH 10/10] sl82c105: " Sergei Shtylyov
2009-10-09 13:36 ` [PATCH] hpt366: kill unused #define's Sergei Shtylyov
2009-10-29 10:09 ` David Miller
2009-11-20 18:52 ` [PATCH] hpt366: add debounce delay to cable_detect() method Sergei Shtylyov
2009-11-20 19:45 ` Alan Cox
2009-12-07 14:57 ` Sergei Shtylyov
2010-09-25 16:49 ` Sergei Shtylyov
2009-12-07 15:03 ` [PATCH] hpt366: fix clock turnaround Sergei Shtylyov
2010-09-25 16:40 ` Sergei Shtylyov
2010-09-25 21:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906151832.51733.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).