linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Frans Pop <elendil@planet.nl>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: David Miller <davem@davemloft.net>,
	sparclinux@vger.kernel.org, linux-ide@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: cmd64x: irq 14: nobody cared - system is dreadfully slow
Date: Mon, 22 Jun 2009 21:01:37 +0200	[thread overview]
Message-ID: <200906222101.38586.elendil@planet.nl> (raw)
In-Reply-To: <200906221938.27574.bzolnier@gmail.com>

On Monday 22 June 2009, Bartlomiej Zolnierkiewicz wrote:
> On Monday 22 June 2009 17:16:04 Frans Pop wrote:
> Thanks.  Please notice 0701 0701 words above -- it means that this
> device reports both SWDMA0 and MWDMA0 enabled at once (which results
> in IDE layer failing DMA tuning).
>
> The patch below should fix it

Yes, this gives back MWDMA2 for hdd.

> and it would be quite interesting to try 
> it on vanilla kernel to see if it helps with unexpected IRQ problem.

Will do later.

> However this still doesn't explain the regression fully -- we had
> ide_id_dma_bug() checks since Dec 2007 (and equivalent
> ide_dma_verbose() ones since almost forever) while 2.6.26 (which works
> fine) is much younger than that.  I suspect that there are some other
> kernel changes coming into the picture (Power Management?).  Would it
> be possible to try 2.6.2[78] and/or bisect this problem further?

I suspect commit 8d64fcd9 "ide: identify data word 53 bit 1 doesn't cover 
words 62 and 63 (take 3)":
@@ -396,15 +393,14 @@ int ide_id_dma_bug(ide_drive_t *drive)
 
 	if (id[ATA_ID_FIELD_VALID] & 4) {
 		if ((id[ATA_ID_UDMA_MODES] >> 8) &&
 		    (id[ATA_ID_MWDMA_MODES] >> 8))
 			goto err_out;
-	} else if (id[ATA_ID_FIELD_VALID] & 2) {
-		if ((id[ATA_ID_MWDMA_MODES] >> 8) &&
-		    (id[ATA_ID_SWDMA_MODES] >> 8))
-			goto err_out;
-	}
+	} else if ((id[ATA_ID_MWDMA_MODES] >> 8) &&
+		   (id[ATA_ID_SWDMA_MODES] >> 8))
+		goto err_out;


The logs I posted were from 2.6.30. I also tried 2.6.29 and that did *not* 
yet have the DMA problem. The commit above is from the 2.6.30 development 
cycle, so that fits. I expect you can verify it from the identify data.

> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] ide: relax DMA info validity checking
>
> There are some broken devices that report multiple DMA xfer modes
> enabled at once (ATA spec doesn't allow it) but otherwise work fine
> with DMA so just delete ide_id_dma_bug().

The question is maybe: are there other devices that currently have dma 
disabled because of the (old) code and would stop working with 
ide_id_dma_bug() completely removed? The conservative thing to do I guess 
would be to reverse 8d64fcd9.


There is one thing I should mention here. I have been seeing the following 
error with this CD drive:
ide-cd: hdd: weird block size 2352
ide-cd: hdd: default to 2kb block size

This was present with 2.6.26 and also now with 2.6.31; not sure about 
older kernels. I initially saw it with a self-burned Debian installation 
CD. I also now see it with an audio CD. It does not seem to affect 
reading the disks: installations go fine and the audio CD plays without 
any problems.

Any risk this may be related to something we've been discussing so far, or 
is this a separate issue?

  reply	other threads:[~2009-06-22 19:01 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-20 21:52 cmd64x: irq 14: nobody cared - system is dreadfully slow Frans Pop
2009-06-21  0:19 ` David Miller
2009-06-21  4:47   ` Frans Pop
2009-06-21 12:46   ` Frans Pop
2009-06-21 13:33     ` Bartlomiej Zolnierkiewicz
2009-06-21 20:14       ` Frans Pop
2009-06-22  1:56     ` David Miller
2009-06-22  4:28       ` Frans Pop
2009-06-22  5:45         ` David Miller
2009-06-22  6:43           ` Frans Pop
2009-06-22  6:44             ` David Miller
2009-06-22 11:21             ` Bartlomiej Zolnierkiewicz
2009-06-22 14:04               ` Frans Pop
2009-06-22 14:39                 ` Bartlomiej Zolnierkiewicz
2009-06-22 15:16                   ` Frans Pop
2009-06-22 17:38                     ` Bartlomiej Zolnierkiewicz
2009-06-22 19:01                       ` Frans Pop [this message]
2009-06-22 21:35                         ` Bartlomiej Zolnierkiewicz
2009-06-23  7:51                           ` [PATCH] ide-cd: Improve "weird block size" error message Frans Pop
2009-06-23  7:57                             ` Borislav Petkov
2009-06-23  8:02                               ` Borislav Petkov
2009-06-23 23:03                                 ` David Miller
2009-06-23  8:20                               ` Frans Pop
2009-06-23 10:59                             ` David Miller
2009-06-23 11:13                               ` Frans Pop
2009-06-23 11:18                                 ` David Miller
2009-06-23 21:30                               ` Frans Pop
2009-06-23 23:01                                 ` David Miller
2009-06-29 11:19                               ` Jan Engelhardt
2009-06-23 10:15                           ` cmd64x: irq 14: nobody cared - system is dreadfully slow David Miller
2009-06-23 14:58                             ` Frans Pop
2009-06-23 16:13                               ` Bartlomiej Zolnierkiewicz
2009-06-23 23:04                                 ` David Miller
2009-06-23 10:47                         ` David Miller
2009-06-23 10:43                 ` David Miller
2009-07-31 14:08                   ` Frans Pop
2009-08-01  5:46                     ` David Miller
2009-08-05 20:43                     ` [stable] " Greg KH
2009-06-21 13:15   ` Bartlomiej Zolnierkiewicz
2009-06-21 21:19     ` David Miller
2009-06-21 22:34       ` Bartlomiej Zolnierkiewicz
2009-06-21 22:57         ` David Miller
2009-06-21 23:13           ` New IDE maintainer (was Re: cmd64x: irq 14: nobody cared - system is dreadfully slow) David Miller
2009-06-21 23:45             ` Bartlomiej Zolnierkiewicz
2009-06-21 23:52               ` New IDE maintainer David Miller
2009-06-22  0:53               ` New IDE maintainer (was Re: cmd64x: irq 14: nobody cared - system is dreadfully slow) Matthew Wilcox
2009-06-22  0:00             ` Stephen Rothwell
2009-06-22  0:20               ` New IDE maintainer David Miller
2009-06-22  3:39             ` New IDE maintainer (was Re: cmd64x: irq 14: nobody cared - system is dreadfully slow) Greg Freemyer
2009-06-22 17:03               ` Jeff Garzik
2009-06-22 17:11                 ` Alan Cox
2009-06-22 17:21                   ` Arnd Bergmann
2009-06-22 17:32                     ` Alan Cox
2009-06-22  3:47         ` cmd64x: irq 14: nobody cared - system is dreadfully slow Frans Pop
2009-06-21 15:43   ` Bartlomiej Zolnierkiewicz
2009-06-21 21:21     ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2009-06-20 21:39 Frans Pop

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200906222101.38586.elendil@planet.nl \
    --to=elendil@planet.nl \
    --cc=bzolnier@gmail.com \
    --cc=davem@davemloft.net \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).