From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/4] scsi: Allow hosts to be flagged as hotpluggable
Date: Thu, 16 Jul 2009 15:38:28 +0100 [thread overview]
Message-ID: <20090716143828.GB13924@srcf.ucam.org> (raw)
In-Reply-To: <4A5F3975.70503@s5r6.in-berlin.de>
On Thu, Jul 16, 2009 at 04:30:13PM +0200, Stefan Richter wrote:
> Matthew Garrett wrote:
> > @@ -447,6 +448,11 @@ struct scsi_host_template {
> > unsigned ordered_tag:1;
> >
> > /*
> > + * True if host supports hotplugging
> > + */
> > + unsigned hotpluggable:1;
> > +
>
> The comment should specify what the actual effects of the flag are.
>
> (Provides the default for Scsi_Host.hotpluggable?)
Ok.
> >
> > + /* 1 if hotpluggable, 0 if not */
> > + unsigned hotpluggable:1;
> > +
>
> Ditto here.
There's no in-kernel effect of this flag - it's just exposed to
userspace.
> (Is used by power management infrastructure to decide over runtime PM
> policy? I.e. don't enter power states which would prevent the port from
> detecting/ reporting hotplug events?)
Exactly.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2009-07-16 14:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-15 23:43 [PATCH 1/4] scsi: Allow hosts to be flagged as hotpluggable Matthew Garrett
2009-07-15 23:43 ` [PATCH 2/4] libata: Flag most SATA ports " Matthew Garrett
2009-07-15 23:43 ` [PATCH 3/4] libata: Make it possible for host drivers to flag hotplug ports Matthew Garrett
2009-07-15 23:43 ` [PATCH 4/4] libata: Allow AHCI to flag ports as not hotpluggable Matthew Garrett
2009-07-16 1:12 ` [PATCH 1/4] scsi: Allow hosts to be flagged as hotpluggable James Bottomley
2009-07-16 1:26 ` Matthew Garrett
2009-07-16 7:59 ` Alan Cox
2009-07-16 11:59 ` Matthew Wilcox
2009-07-16 14:30 ` Stefan Richter
2009-07-16 14:36 ` Stefan Richter
2009-07-16 14:44 ` Matthew Garrett
2009-07-16 14:38 ` Matthew Garrett [this message]
2009-07-16 14:43 ` James Bottomley
2009-07-16 14:45 ` Matthew Garrett
2009-07-16 14:53 ` James Bottomley
2009-07-16 14:55 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090716143828.GB13924@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).