From: Jens Axboe <jens.axboe@oracle.com>
To: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: jeff@garzik.org, htejun@gmail.com
Subject: [PATCH] libata: use single threaded work queue
Date: Wed, 19 Aug 2009 13:25:54 +0200 [thread overview]
Message-ID: <20090819112554.GY12579@kernel.dk> (raw)
Hi,
On boxes with lots of CPUs, we have so many kernel threads it's not
funny. The basic problem is that create_workqueue() creates a per-cpu
thread, where we could easily get by with a single thread for a lot of
cases.
One such case appears to be ata_wq. You want at most one per pio drive,
not one per CPU. I'd suggest just dropping it to a single threaded wq.
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 072ba5e..0d78628 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -6580,7 +6580,7 @@ static int __init ata_init(void)
{
ata_parse_force_param();
- ata_wq = create_workqueue("ata");
+ ata_wq = create_singlethread_workqueue("ata");
if (!ata_wq)
goto free_force_tbl;
--
Jens Axboe
next reply other threads:[~2009-08-19 11:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-19 11:25 Jens Axboe [this message]
2009-08-19 11:59 ` [PATCH] libata: use single threaded work queue Jeff Garzik
2009-08-19 12:04 ` Jens Axboe
2009-08-19 12:14 ` Mark Lord
2009-08-19 12:23 ` Jens Axboe
2009-08-19 13:22 ` Jeff Garzik
2009-08-19 13:28 ` Jeff Garzik
2009-08-19 14:11 ` Tejun Heo
2009-08-19 15:21 ` Alan Cox
2009-08-19 15:53 ` Tejun Heo
2009-08-19 16:15 ` Alan Cox
2009-08-19 16:58 ` Tejun Heo
2009-08-19 17:23 ` Alan Cox
2009-08-20 12:46 ` Tejun Heo
2009-08-20 11:39 ` Stefan Richter
2009-08-20 12:11 ` Stefan Richter
2009-08-19 22:22 ` Benjamin Herrenschmidt
2009-08-20 12:47 ` Tejun Heo
2009-08-20 12:48 ` Tejun Heo
2009-08-20 14:28 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090819112554.GY12579@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).