From: Jens Axboe <jens.axboe@oracle.com>
To: Tejun Heo <tj@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
alan@lxorguk.ukuu.org.uk, jeff@garzik.org, dhowells@redhat.com
Subject: Re: [PATCH 0/3] Convert libata pio task to slow-work
Date: Fri, 28 Aug 2009 09:06:42 +0200 [thread overview]
Message-ID: <20090828070641.GR12579@kernel.dk> (raw)
In-Reply-To: <4A9780EF.1030102@kernel.org>
On Fri, Aug 28 2009, Tejun Heo wrote:
> >>> Care to post it? I know you don't think it's perfect yet, but it would
> >>> make a lot more sense to throw effort into this rather than waste time
> >>> on partial solutions.
> >> I have this printed out code with full of red markings from proof
> >> reading and flush implementation is mostly broken. Please give me a
> >> couple of days. I'll post a rough unsplit version which at least
> >> compiles with the planned changes applied by the end of the week. :-)
> >
> > Alright, fair enough.
> >
> > One question - do the 'exposed' workqueues (the ones that drivers
> > allocate/create) sitting in front of the global cpu queue allow more
> > than one thread per cpu, or is that property retained for the global cpu
> > queue (where it is a necessity)?
>
> The exposed workqueues basically just play the gateway and don't have
> threads associated with it, well, at least not the normal ones. It
> may have single dedicated thread which usually isn't used but only
> gets summoned when a queue stall is detected (new thread needs to be
> created but blocks on allocation kind of situation). So, only the
> global cpu queue has normal workers and there are multiple per cpu and
> they're shared by all exported workqueues.
Thanks for the clarification, it answers the question on what level of
functionality is observed by the exported workqueues. Sounds good!
--
Jens Axboe
next prev parent reply other threads:[~2009-08-28 7:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-27 9:08 [PATCH 0/3] Convert libata pio task to slow-work Jens Axboe
2009-08-27 9:08 ` [PATCH 1/3] slow-work: add delayed_slow_work support Jens Axboe
2009-08-27 9:08 ` [PATCH 2/3] slow-work: add support for cancellation of slow work Jens Axboe
2009-08-27 9:08 ` [PATCH 3/3] libata: switch pio task from workqueue to slow-work Jens Axboe
2009-08-27 9:14 ` [PATCH 2/3] slow-work: add support for cancellation of slow work Jens Axboe
2009-08-27 9:18 ` [PATCH 2/3] slow-work: add support for cancellation of slow work (updated) Jens Axboe
2009-08-27 12:36 ` [PATCH 0/3] Convert libata pio task to slow-work Tejun Heo
2009-08-27 12:49 ` Jens Axboe
2009-08-27 12:58 ` Tejun Heo
2009-08-27 18:49 ` Jens Axboe
2009-08-28 7:02 ` Tejun Heo
2009-08-28 7:06 ` Jens Axboe [this message]
2009-08-31 3:24 ` [very-early-draft-unsplit PATCH] workqueue: implement global cpu workqueue Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090828070641.GR12579@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dhowells@redhat.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).