From: Matthew Wilcox <matthew@wil.cx>
To: Mark Lord <liml@rtr.ca>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org, jens.axboe@oracle.com,
dwmw2@infradead.org
Subject: Re: [PATCH 6/7] block: allow large discard requests
Date: Sat, 29 Aug 2009 20:50:22 -0600 [thread overview]
Message-ID: <20090830025022.GE22870@parisc-linux.org> (raw)
In-Reply-To: <4A99E89E.9020204@rtr.ca>
On Sat, Aug 29, 2009 at 10:49:02PM -0400, Mark Lord wrote:
> Pardon my cursory review, but I don't see where this
> patch set allows for more than a single extent/range
> of sectors per TRIM command.
It doesn't.
> If it still does not group many extents into a single TRIM,
> then it will be far to slow to be useful at all for SATA.
That depends on the firmware. I do have plans to group the extents,
but let's get something working before making it quick.
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2009-08-30 2:50 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-29 23:03 [PATCH 0/7] discard support revisited Christoph Hellwig
2009-08-29 23:03 ` [PATCH 1/7] Make DISCARD_BARRIER and DISCARD_NOBARRIER writes instead of reads Christoph Hellwig
2009-09-03 17:52 ` David Woodhouse
2009-09-03 17:56 ` Matthew Wilcox
2009-08-29 23:03 ` [PATCH 2/7] block: use blkdev_issue_discard in blk_ioctl_discard Christoph Hellwig
2009-09-01 9:06 ` Steven Whitehouse
2009-09-11 22:26 ` Christoph Hellwig
2009-09-14 9:40 ` Jens Axboe
2009-08-29 23:03 ` [PATCH 3/7] block: discard may need to allocate pages Christoph Hellwig
2009-08-29 23:03 ` [PATCH 4/7] sd: add support for WRITE SAME (16) with unmap bit Christoph Hellwig
2009-08-30 0:43 ` Douglas Gilbert
2009-08-30 1:05 ` Christoph Hellwig
2009-08-30 2:43 ` Douglas Gilbert
2009-08-30 2:48 ` Christoph Hellwig
2009-08-30 11:12 ` Sergei Shtylyov
2009-08-30 17:14 ` Christoph Hellwig
2009-08-29 23:03 ` [PATCH 5/7] libata: Add support for TRIM Christoph Hellwig
2009-08-29 23:03 ` [PATCH 6/7] block: allow large discard requests Christoph Hellwig
2009-08-30 2:49 ` Mark Lord
2009-08-30 2:50 ` Matthew Wilcox [this message]
2009-08-30 2:52 ` Mark Lord
2009-08-30 2:56 ` Christoph Hellwig
2009-08-29 23:03 ` [PATCH 7/7] xfs: add batches discard support Christoph Hellwig
2009-08-29 23:37 ` [PATCH 0/7] discard support revisited Matthew Wilcox
2009-08-30 2:15 ` Christoph Hellwig
2009-08-30 3:03 ` Matthew Wilcox
2009-08-30 20:17 ` James Bottomley
2009-08-30 21:42 ` Matthew Wilcox
2009-08-30 22:48 ` Christoph Hellwig
2009-09-02 19:46 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090830025022.GE22870@parisc-linux.org \
--to=matthew@wil.cx \
--cc=dwmw2@infradead.org \
--cc=hch@infradead.org \
--cc=jens.axboe@oracle.com \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).