From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Arjan van de Ven <arjan@linux.intel.com>,
Alan Cox <alan@linux.intel.com>, Jeff Garzik <jgarzik@redhat.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata_piix: parallel scanning on PATA needs an extra locking
Date: Sun, 30 Aug 2009 16:33:19 +0200 [thread overview]
Message-ID: <200908301633.19978.bzolnier@gmail.com> (raw)
In-Reply-To: <20090830151321.57bc33eb@lxorguk.ukuu.org.uk>
On Sunday 30 August 2009 16:13:21 Alan Cox wrote:
> > Lets fix all such races by adding an extra locking to ->set_piomode
> > and ->set_dmamode methods for PATA controllers.
>
> Would it not be better to take the host lock in libata-core for these
> cases so that we fix all the adapters in one swoop. Even if we are doing
> this lock taking in the controller specific code it seems the right lock
> to use ?
Yes, taking the host lock would be a preferred solution in the long-term
and would allow us to enable parallel scanning for many other controllers
later.
The downside is that it requires somebody to audit all host drivers before
making such change and much more testing time..
> Looks fine as a temproary quickfix tho
That was the goal of the patch (I verified the issue only yesterday).
prev parent reply other threads:[~2009-08-30 14:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-30 12:56 [PATCH] ata_piix: parallel scanning on PATA needs an extra locking Bartlomiej Zolnierkiewicz
2009-08-30 14:13 ` Alan Cox
2009-08-30 14:33 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908301633.19978.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=alan@linux.intel.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arjan@linux.intel.com \
--cc=jgarzik@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).