From: Greg KH <greg@kroah.com>
To: Tejun Heo <tj@kernel.org>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>,
stable@kernel.org, Jeff Garzik <jeff@garzik.org>,
Thomas Jarosch <thomas.jarosch@intra2net.com>
Subject: Re: [stable] [PATCH] ahci: restore pci_intx() handling
Date: Wed, 16 Sep 2009 08:48:07 -0700 [thread overview]
Message-ID: <20090916154807.GA27478@kroah.com> (raw)
In-Reply-To: <4AB1058F.3070108@kernel.org>
On Thu, Sep 17, 2009 at 12:34:39AM +0900, Tejun Heo wrote:
> Commit a5bfc4714b3f01365aef89a92673f2ceb1ccf246 dropped explicit
> pci_intx() manipulation from ahci because it seemed unnecessary and
> ahci doesn't seem to be the right place to be tweaking it if it were.
> This was largely okay but there are exceptions. There was one on an
> embedded platform which was fixed via firmware and now bko#14124
> reports it on a HP DL320.
>
> http://bugzilla.kernel.org/show_bug.cgi?id=14124
>
> I still think this isn't something libata drivers should be caring
> about (the only ones which are calling pci_intx() explicitly are
> libata ones and one other driver) but for now reverting the change
> seems to be the right thing to do.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Reported-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
In the future, for stuff that you want sent to stable, can you also add:
Cc: stable <stable@kernel.org>
in this signed-off-by area? That way, when the patch hits Linus's tree,
we get automatically notified of it and I don't have to dig back through
log files to try to find out if your commit has made it in or not.
thanks,
greg "drowning in -stable patches" k-h
next prev parent reply other threads:[~2009-09-16 15:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-16 15:34 [PATCH] ahci: restore pci_intx() handling Tejun Heo
2009-09-16 15:48 ` Greg KH [this message]
2009-09-16 15:52 ` [stable] " Tejun Heo
2009-09-17 20:49 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090916154807.GA27478@kroah.com \
--to=greg@kroah.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=stable@kernel.org \
--cc=thomas.jarosch@intra2net.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).