* [PATCH 1/4] pata_atp867x: fix it to not claim MWDMA support
@ 2009-10-06 22:26 Bartlomiej Zolnierkiewicz
2009-10-07 1:03 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2009-10-06 22:26 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Jung-Ik Lee (John), linux-ide
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: [PATCH] pata_atp867x: fix it to not claim MWDMA support
MWDMA modes are not supported by this driver currently.
Acked-by: Jung-Ik (John) Lee <jilee@google.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ata/pata_atp867x.c | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
Index: b/drivers/ata/pata_atp867x.c
===================================================================
--- a/drivers/ata/pata_atp867x.c
+++ b/drivers/ata/pata_atp867x.c
@@ -118,20 +118,13 @@ struct atp867x_priv {
int pci66mhz;
};
-static inline u8 atp867x_speed_to_mode(u8 speed)
-{
- return speed - XFER_UDMA_0 + 1;
-}
-
static void atp867x_set_dmamode(struct ata_port *ap, struct ata_device *adev)
{
struct pci_dev *pdev = to_pci_dev(ap->host->dev);
struct atp867x_priv *dp = ap->private_data;
u8 speed = adev->dma_mode;
u8 b;
- u8 mode;
-
- mode = atp867x_speed_to_mode(speed);
+ u8 mode = speed - XFER_UDMA_0 + 1;
/*
* Doc 6.6.9: decrease the udma mode value by 1 for safer UDMA speed
@@ -471,7 +464,6 @@ static int atp867x_init_one(struct pci_d
static const struct ata_port_info info_867x = {
.flags = ATA_FLAG_SLAVE_POSS,
.pio_mask = ATA_PIO4,
- .mwdma_mask = ATA_MWDMA2,
.udma_mask = ATA_UDMA6,
.port_ops = &atp867x_ops,
};
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 1/4] pata_atp867x: fix it to not claim MWDMA support
2009-10-06 22:26 [PATCH 1/4] pata_atp867x: fix it to not claim MWDMA support Bartlomiej Zolnierkiewicz
@ 2009-10-07 1:03 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2009-10-07 1:03 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: Jung-Ik Lee (John), linux-ide
On 10/06/2009 06:26 PM, Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz<bzolnier@gmail.com>
> Subject: [PATCH] pata_atp867x: fix it to not claim MWDMA support
>
> MWDMA modes are not supported by this driver currently.
>
> Acked-by: Jung-Ik (John) Lee<jilee@google.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz<bzolnier@gmail.com>
> ---
> drivers/ata/pata_atp867x.c | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
applied 1-4
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-10-07 1:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-06 22:26 [PATCH 1/4] pata_atp867x: fix it to not claim MWDMA support Bartlomiej Zolnierkiewicz
2009-10-07 1:03 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).