From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: torvalds@linux-foundation.org, joao.ramos@inov.pt,
david@fries.net, d.stussy@yahoo.com, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Revert "Revert "ide: try to use PIO Mode 0 during probe if possible""
Date: Wed, 7 Oct 2009 00:52:37 +0200 [thread overview]
Message-ID: <200910070052.37964.bzolnier@gmail.com> (raw)
In-Reply-To: <20091006.154120.153174904.davem@davemloft.net>
On Wednesday 07 October 2009 00:41:20 David Miller wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Date: Wed, 7 Oct 2009 00:27:45 +0200
>
> > The root cause of reported system hangs was (now fixed) sis5513 bug
> > and not "ide: try to use PIO Mode 0 during probe if possible" change
> > (commit 6029336426a2b43e4bc6f4a84be8789a047d139e) so the revert was
> > incorrect (it simply replaced one regression with the other one).
>
> What is this older "regression" fixed by the PIO-0 change?
>
> You're not explaining it and neither does the commit message for the
> PIO-0 change.
It does:
| Subject: [PATCH] sis5513: fix PIO setup for ATAPI devices
|
| Clear prefetch setting before potentially (re-)enabling it in
| config_drive_art_rwp() so the transition of the device type on
| the port from ATA to ATAPI (i.e. during warm-plug operation)
| is handled correctly.
and the empty port defaults to ATA-like behavior for the initial PIO setup.
> Please, fill us in :-)
Just connect the dots.. :)
next prev parent reply other threads:[~2009-10-06 22:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-06 22:27 [PATCH 2/2] Revert "Revert "ide: try to use PIO Mode 0 during probe if possible"" Bartlomiej Zolnierkiewicz
2009-10-06 22:41 ` David Miller
2009-10-06 22:52 ` Bartlomiej Zolnierkiewicz [this message]
2009-10-06 22:57 ` David Miller
2009-10-06 23:13 ` Bartlomiej Zolnierkiewicz
2009-10-06 23:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910070052.37964.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=d.stussy@yahoo.com \
--cc=davem@davemloft.net \
--cc=david@fries.net \
--cc=joao.ramos@inov.pt \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox