From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH] pata_sc1200: Fix crash on boot Date: Tue, 13 Oct 2009 18:56:37 -0700 Message-ID: <20091013185637.870369c8.akpm@linux-foundation.org> References: <20091006150737.9610.81541.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:34633 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753859AbZJNB6o (ORCPT ); Tue, 13 Oct 2009 21:58:44 -0400 In-Reply-To: <20091006150737.9610.81541.stgit@localhost.localdomain> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Alan Cox Cc: jeff@garzik.org, linux-kernel@vger.kernel.org, stable@kernel.org, "Alexandros C. Couloumbis" , linux-ide@vger.kernel.org On Tue, 06 Oct 2009 16:07:51 +0100 Alan Cox wrote: > The SC1200 needs a NULL terminator or it may cause a crash on boot. > > Bug #14227 > > Also correct a bogus comment as the driver had serializing added so can run > dual port. > > Signed-off-by: Alan Cox > --- > > drivers/ata/pata_sc1200.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > > diff --git a/drivers/ata/pata_sc1200.c b/drivers/ata/pata_sc1200.c > index f49814d..3bbed83 100644 > --- a/drivers/ata/pata_sc1200.c > +++ b/drivers/ata/pata_sc1200.c > @@ -235,8 +235,7 @@ static int sc1200_init_one(struct pci_dev *dev, const struct pci_device_id *id) > .udma_mask = ATA_UDMA2, > .port_ops = &sc1200_port_ops > }; > - /* Can't enable port 2 yet, see top comments */ > - const struct ata_port_info *ppi[] = { &info, }; > + const struct ata_port_info *ppi[] = { &info, NULL }; > > return ata_pci_sff_init_one(dev, ppi, &sc1200_sht, NULL); > } This patch applies to 2.6.31 and 2.6.30 (at least). How far back should it be ported? There was no Cc:stable in the changelog. There was no Cc:stable in the mail headers. Nor cc:linux-ide. Adding a Reported-by: is nice. Please use the form Addresses http://bugzilla.kernel.org/show_bug.cgi?id=14227 when mentioning bugzilla reports within changelogs. To provide a nice greppable pattern for those people who might close off old reports for us.