Re: [PATCH] libata: add TRIM support

[Christoph Hellwig <hch@infradead.org>]

On Tue, Nov 17, 2009 at 09:04:54AM -0500, Mark Lord wrote:
> Where is the code that sets up the multi-entry trim list
> that this command requires as data?  It's probably there,
> but I don't see it (blind or something).

It's not there, as the SCSI command we're translating only supports a
single range.  We can later also add UNMAP support, but it's a lot more
complicated to translate due to the different data formats.  My plan
for now is to get basic discard support done in all layers and then
later optimize it when all infrastructure is in place.

> And, where is the per-ATA-host flag to enable use of this feature,
> with the default being DISABLED.  Or vice versa, if you want to test
> all the supported controllers first for compatibility.
>
> Eg. sata_mv, sata_sil, .. won't work as-is with this command.

I can certainly add a blacklist, do you have a complete list of
controllers that should be blacklisted.  Also is there a good reason
why they are blacklisted or ist just controller bugs?