From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 4/5] pata: Update experimental tags Date: Wed, 18 Nov 2009 20:16:36 +0100 Message-ID: <200911182016.36720.bzolnier@gmail.com> References: <20091117144450.15430.83450.stgit@localhost.localdomain> <20091118184125.623e063d@lxorguk.ukuu.org.uk> <4B04413D.30302@ru.mvista.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-yx0-f187.google.com ([209.85.210.187]:57788 "EHLO mail-yx0-f187.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932601AbZKRTRT (ORCPT ); Wed, 18 Nov 2009 14:17:19 -0500 In-Reply-To: <4B04413D.30302@ru.mvista.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Sergei Shtylyov Cc: Alan Cox , Alan Cox , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org On Wednesday 18 November 2009 19:47:25 Sergei Shtylyov wrote: > Hello. > > Alan Cox wrote: > > >>Having separate drivers wasn't the best decisions from the maintainability > >>point-of-view. It added needless complexity (different chips share the same > > > It was most definitely a good decision, having maintained both sets of > > Separating HPT36x was grounded enough decision but I can't say the same > of the separation of HPT3xxN. When it comes to HPT36x I would agree if we would be developing completely from scratch but due to historical reasons we share UDMA blacklists between HPT36x and HPT37x. It is not worth it in terms of potential regressions to try to untangle them nowadays. > > drivers at different times. It also makes it possible to do things the > > way highpoint does > > Oh, don't remind me of that stupid code mostly not worth copying from... > > >>PCI IDs which make detection across multiple drivers extremely painful) and > >>confusion (i.e. would you have guessed that HPT302 is supported by pata_hpt37x > >>while HPT302N by pata_hpt3x2n?). > > How about HPT371N? ;-) Not a problem, this one is unsupported according to help entries. ;) -- Bartlomiej Zolnierkiewicz