From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 4/5] pata: Update experimental tags Date: Thu, 19 Nov 2009 16:16:34 +0100 Message-ID: <200911191616.35033.bzolnier@gmail.com> References: <20091117144450.15430.83450.stgit@localhost.localdomain> <20091119143351.1d0e2c59@lxorguk.ukuu.org.uk> <200911191550.25476.bzolnier@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from ey-out-2122.google.com ([74.125.78.25]:39928 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750715AbZKSPRH (ORCPT ); Thu, 19 Nov 2009 10:17:07 -0500 In-Reply-To: <200911191550.25476.bzolnier@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Alan Cox Cc: Alan Cox , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org On Thursday 19 November 2009 15:50:25 Bartlomiej Zolnierkiewicz wrote: > On Thursday 19 November 2009 15:33:51 Alan Cox wrote: > > On Thu, 19 Nov 2009 15:17:14 +0100 > > Bartlomiej Zolnierkiewicz wrote: > > > > > On Thursday 19 November 2009 14:16:36 Alan Cox wrote: > > > > > Only pata_hpt37x has broken cable detection while pata_hpt3x2n is > > > > > okay. ;) > > > > > > > > I think you have that backwards according to the vendor drivers. 3x2n > > > > looks like it needs adjusting. > > > > > > lol, just fix the damn pata_hpt37x driver _lacking_ ->cable_detect method.. > > > > It doesn't need one. It still sets the cable type in the pre reset > > function as the older drivers that haven't converted to a cable_detect > > method do. > > If you know about other drivers still using ->pre_reset for cable detection > please let us know because they need fixing ASAP. No need for it any longer. I'll send patches later. -- Bartlomiej Zolnierkiewicz