From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 4/5] pata: Update experimental tags Date: Thu, 19 Nov 2009 22:49:16 +0100 Message-ID: <200911192249.16860.bzolnier@gmail.com> References: <20091117144450.15430.83450.stgit@localhost.localdomain> <200911182056.16517.bzolnier@gmail.com> <4B05BADF.1010205@garzik.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from ey-out-2122.google.com ([74.125.78.27]:45147 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755614AbZKSVty (ORCPT ); Thu, 19 Nov 2009 16:49:54 -0500 In-Reply-To: <4B05BADF.1010205@garzik.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Jeff Garzik Cc: Alan Cox , Alan Cox , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org On Thursday 19 November 2009 22:38:39 Jeff Garzik wrote: > On 11/18/2009 02:56 PM, Bartlomiej Zolnierkiewicz wrote: > > On Wednesday 18 November 2009 20:07:07 Bartlomiej Zolnierkiewicz wrote: > >> On Wednesday 18 November 2009 19:41:25 Alan Cox wrote: > >>>> Maybe they are 'stable' but when it comes to features they are behind hpt366 > >>>> (i.e. they lack PCI PM), which is also much cleaner than your drivers, easier > >>>> to understand and much smaller.. > >>> > >>> 37x and 3xn lack PCI PM. Added to the TODO list. > >>> > >>> The smaller size is a bit questionable given its mostly comments, and > >>> three drivers versus one. > >> > >> I wonder what you find 'questionable' in the numbers given.. > > > > BTW we can immediately reclaim 300 LOC by simply merging drivers back.. > > Merging drivers is a big pain for distributions and end users, even with > the new module_alias facility. Could please explain in more detail 'a big pain' part? > Absent stronger justification, libata remains with separate drivers, > even if that means some code duplication. I can always hold my own tree with such changes if needed. -- Bartlomiej Zolnierkiewicz