From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pata_it8213: MWDMA0 is unsupported
Date: Thu, 26 Nov 2009 19:00:11 +0100 [thread overview]
Message-ID: <200911261900.11506.bzolnier@gmail.com> (raw)
In-Reply-To: <4B0EB986.2010801@ru.mvista.com>
On Thursday 26 November 2009 06:23:18 pm Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> >>MWDMA0 timings cannot be met with the PIIX based controller
> >>programming interface.
>
> >>This change should be safe as this is how we have been doing
> >>things in IDE it8213 host driver for years.
>
> >>Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> >>---
> >>Verified with the documentation (similar case as with pata_efar).
>
> > Uhhh, no...
>
> > Too many damn drivers.
>
> > Too much damn duplication.
>
> > Too much damn subtle differences here and there.
>
> > The hardware is probably fine for MWMDA0 when it comes to pata_{efar,it8213},
> > it just not documented properly in the data sheet.
>
> How so with pata_efar? The active/recovery bitfields are still 2-bit
> wide, no?
Yes but when TIMEx bit is disabled we are using XFER_PIO_SLOW timings.
All data sheets including original Intel ones are a complete crap when it
comes to explicitly documenting this behavior.
--
Bartlomiej Zolnierkiewicz
next prev parent reply other threads:[~2009-11-26 18:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-26 16:28 [PATCH] pata_it8213: MWDMA0 is unsupported Bartlomiej Zolnierkiewicz
2009-11-26 17:00 ` Bartlomiej Zolnierkiewicz
2009-11-26 17:23 ` Sergei Shtylyov
2009-11-26 18:00 ` Bartlomiej Zolnierkiewicz [this message]
2009-11-26 18:03 ` Bartlomiej Zolnierkiewicz
2009-11-26 18:12 ` Sergei Shtylyov
2009-11-26 18:27 ` Bartlomiej Zolnierkiewicz
2009-11-26 18:33 ` Sergei Shtylyov
2009-11-26 18:47 ` Sergei Shtylyov
2009-12-03 21:04 ` Jeff Garzik
2009-12-03 22:06 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911261900.11506.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).