From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH] pata_it8213: MWDMA0 is unsupported Date: Thu, 26 Nov 2009 19:03:01 +0100 Message-ID: <200911261903.01199.bzolnier@gmail.com> References: <200911261728.36433.bzolnier@gmail.com> <4B0EB986.2010801@ru.mvista.com> <200911261900.11506.bzolnier@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ew0-f219.google.com ([209.85.219.219]:48689 "EHLO mail-ew0-f219.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750872AbZKZSLw (ORCPT ); Thu, 26 Nov 2009 13:11:52 -0500 In-Reply-To: <200911261900.11506.bzolnier@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Sergei Shtylyov , Alan Cox Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org On Thursday 26 November 2009 07:00:11 pm Bartlomiej Zolnierkiewicz wrote: > On Thursday 26 November 2009 06:23:18 pm Sergei Shtylyov wrote: > > Bartlomiej Zolnierkiewicz wrote: > > > > >>MWDMA0 timings cannot be met with the PIIX based controller > > >>programming interface. > > > > >>This change should be safe as this is how we have been doing > > >>things in IDE it8213 host driver for years. > > > > >>Signed-off-by: Bartlomiej Zolnierkiewicz > > >>--- > > >>Verified with the documentation (similar case as with pata_efar). > > > > > Uhhh, no... > > > > > Too many damn drivers. > > > > > Too much damn duplication. > > > > > Too much damn subtle differences here and there. > > > > > The hardware is probably fine for MWMDA0 when it comes to pata_{efar,it8213}, > > > it just not documented properly in the data sheet. > > > > How so with pata_efar? The active/recovery bitfields are still 2-bit > > wide, no? > > Yes but when TIMEx bit is disabled we are using XFER_PIO_SLOW timings. > > All data sheets including original Intel ones are a complete crap when it > comes to explicitly documenting this behavior. OTOH all drivers set TIMEx for MWDMA0 currently.. ? -- Bartlomiej Zolnierkiewicz