From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: linux-ide@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Sergei Shtylyov <sshtylyov@ru.mvista.com>
Subject: [PATCH] pata_hpt366: add enablebits checking
Date: Fri, 27 Nov 2009 19:53:51 +0100 [thread overview]
Message-ID: <200911271953.51400.bzolnier@gmail.com> (raw)
Based on Sergei's older work on IDE hpt366 host driver.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ata/pata_hpt366.c | 32 ++++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
Index: b/drivers/ata/pata_hpt366.c
===================================================================
--- a/drivers/ata/pata_hpt366.c
+++ b/drivers/ata/pata_hpt366.c
@@ -204,6 +204,37 @@ static int hpt36x_cable_detect(struct at
return ATA_CBL_PATA80;
}
+/**
+ * hpt36x_prereset - perform reset handling
+ * @link: ATA link to reset
+ * @deadline: deadline jiffies for the operation
+ *
+ * Perform the initial reset handling for the HPT36x.
+ */
+
+static int hpt36x_prereset(struct ata_link *link, unsigned long deadline)
+{
+ static const struct pci_bits hpt36x_enable_bits[] = {
+ { 0x50, 1, 0x10, 0x10 },
+ { 0x50, 1, 0x20, 0x20 }
+ };
+
+ struct ata_port *ap = link->ap;
+ struct pci_dev *pdev = to_pci_dev(ap->host->dev);
+
+ /*
+ * HPT36x chips have one channel per function and have
+ * both channel enable bits located differently and visible
+ * to both functions -- really stupid design decision... :-(
+ * Bit 4 is for the primary channel, bit 5 for the secondary.
+ */
+ if (!pci_test_config_bits(pdev,
+ &hpt36x_enable_bits[PCI_FUNC(pdev->devfn) & 1]))
+ return -ENOENT;
+
+ return ata_sff_prereset(link, deadline);
+}
+
static void hpt366_set_mode(struct ata_port *ap, struct ata_device *adev,
u8 mode)
{
@@ -284,6 +315,7 @@ static struct scsi_host_template hpt36x_
static struct ata_port_operations hpt366_port_ops = {
.inherits = &ata_bmdma32_port_ops,
+ .prereset = hpt36x_prereset,
.cable_detect = hpt36x_cable_detect,
.mode_filter = hpt366_filter,
.set_piomode = hpt366_set_piomode,
reply other threads:[~2009-11-27 18:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911271953.51400.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).