linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] slc90e66: fix UDMA handling
@ 2009-11-30 18:55 Bartlomiej Zolnierkiewicz
  2009-11-30 19:01 ` Sergei Shtylyov
  0 siblings, 1 reply; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2009-11-30 18:55 UTC (permalink / raw)
  To: linux-ide; +Cc: linux-kernel, David Miller

Fix checking of the currently programmed UDMA mode.

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
 drivers/ide/slc90e66.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Index: b/drivers/ide/slc90e66.c
===================================================================
--- a/drivers/ide/slc90e66.c
+++ b/drivers/ide/slc90e66.c
@@ -92,8 +92,7 @@ static void slc90e66_set_dma_mode(ide_hw
 
 		if (!(reg48 & u_flag))
 			pci_write_config_word(dev, 0x48, reg48|u_flag);
-		/* FIXME: (reg4a & a_speed) ? */
-		if ((reg4a & u_speed) != u_speed) {
+		if ((reg4a & a_speed) != u_speed) {
 			pci_write_config_word(dev, 0x4a, reg4a & ~a_speed);
 			pci_read_config_word(dev, 0x4a, &reg4a);
 			pci_write_config_word(dev, 0x4a, reg4a|u_speed);

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] slc90e66: fix UDMA handling
  2009-11-30 18:55 [PATCH] slc90e66: fix UDMA handling Bartlomiej Zolnierkiewicz
@ 2009-11-30 19:01 ` Sergei Shtylyov
  0 siblings, 0 replies; 2+ messages in thread
From: Sergei Shtylyov @ 2009-11-30 19:01 UTC (permalink / raw)
  To: Bartlomiej Zolnierkiewicz; +Cc: linux-ide, linux-kernel, David Miller

Hello.

Bartlomiej Zolnierkiewicz wrote:

> Fix checking of the currently programmed UDMA mode.

> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

MBR, Sergei

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-11-30 19:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-30 18:55 [PATCH] slc90e66: fix UDMA handling Bartlomiej Zolnierkiewicz
2009-11-30 19:01 ` Sergei Shtylyov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).