From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: [PATCH 4/5] libata/sff: Use ops->bmdma_stop instead of ata_bmdma_stop() Date: Tue, 01 Dec 2009 18:08:33 +1100 Message-ID: <20091201070833.CC084B7BD9@ozlabs.org> Return-path: Received: from ozlabs.org ([203.10.76.45]:43799 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753330AbZLAHI1 (ORCPT ); Tue, 1 Dec 2009 02:08:27 -0500 Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: linux-ide@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org, jeff@garzik.org, tj@kernel.org In libata-sff, ata_sff_post_internal_cmd() directly calls ata_bmdma_stop() instead of ap->ops->bmdma_stop(). This can be a problem for controllers that use their own bmdma_stop for which the generic sff one isn't suitable Signed-off-by: Benjamin Herrenschmidt --- drivers/ata/libata-sff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-work.orig/drivers/ata/libata-sff.c 2009-12-01 17:48:27.000000000 +1100 +++ linux-work/drivers/ata/libata-sff.c 2009-12-01 17:48:48.000000000 +1100 @@ -2384,7 +2384,7 @@ void ata_sff_post_internal_cmd(struct at ap->hsm_task_state = HSM_ST_IDLE; if (ap->ioaddr.bmdma_addr) - ata_bmdma_stop(qc); + ap->ops->bmdma_stop(qc); spin_unlock_irqrestore(ap->lock, flags); }