From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: linux-ide@vger.kernel.org
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>
Subject: [PATCH 1/6] alim15x3: remove obsolete and dangerous wdc_udma parameter
Date: Thu, 03 Dec 2009 20:51:54 +0100 [thread overview]
Message-ID: <20091203195154.9093.14693.sendpatchset@localhost> (raw)
In-Reply-To: <20091203195145.9093.88261.sendpatchset@localhost>
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: [PATCH] alim15x3: remove obsolete and dangerous wdc_udma parameter
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ide/alim15x3.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
Index: b/drivers/ide/alim15x3.c
===================================================================
--- a/drivers/ide/alim15x3.c
+++ b/drivers/ide/alim15x3.c
@@ -40,16 +40,6 @@
#define DRV_NAME "alim15x3"
/*
- * Allow UDMA on M1543C-E chipset for WDC disks that ignore CRC checking
- * (this is DANGEROUS and could result in data corruption).
- */
-static int wdc_udma;
-
-module_param(wdc_udma, bool, 0);
-MODULE_PARM_DESC(wdc_udma,
- "allow UDMA on M1543C-E chipset for WDC disks (DANGEROUS)");
-
-/*
* ALi devices are not plug in. Otherwise these static values would
* need to go. They ought to go away anyway
*/
@@ -132,7 +122,7 @@ static u8 ali_udma_filter(ide_drive_t *d
if (m5229_revision > 0x20 && m5229_revision < 0xC2) {
if (drive->media != ide_disk)
return 0;
- if (wdc_udma == 0 && chip_is_1543c_e &&
+ if (chip_is_1543c_e &&
strstr((char *)&drive->id[ATA_ID_PROD], "WDC "))
return 0;
}
next prev parent reply other threads:[~2009-12-03 19:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 19:51 [PATCH 0/6] ide: dead/stale code removal Bartlomiej Zolnierkiewicz
2009-12-03 19:51 ` Bartlomiej Zolnierkiewicz [this message]
2009-12-03 19:52 ` [PATCH 2/6] cmd64x: remove no longer needed debugging code Bartlomiej Zolnierkiewicz
2009-12-03 21:38 ` Sergei Shtylyov
2009-12-03 19:52 ` [PATCH 3/6] cy82c693: " Bartlomiej Zolnierkiewicz
2009-12-03 19:52 ` [PATCH 4/6] pdc202xx_old: " Bartlomiej Zolnierkiewicz
2009-12-03 21:42 ` Sergei Shtylyov
2009-12-03 19:52 ` [PATCH 5/6] sis5513: remove stale TODO Bartlomiej Zolnierkiewicz
2009-12-03 19:52 ` [PATCH 6/6] sl82c105: remove no longer needed debugging code Bartlomiej Zolnierkiewicz
2009-12-03 21:34 ` Sergei Shtylyov
2009-12-03 19:54 ` [PATCH 0/6] ide: dead/stale code removal Bartlomiej Zolnierkiewicz
2009-12-03 21:25 ` David Miller
2009-12-03 20:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091203195154.9093.14693.sendpatchset@localhost \
--to=bzolnier@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).