From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Alan Cox <alan@linux.intel.com>,
Sergei Shtylyov <sshtylyov@ru.mvista.com>,
linux-ide@vger.kernel.org, jeff@garzik.org, davem@davemloft.net
Subject: Re: [PATCH 2/6] pata_sis: Implement MWDMA for the UDMA 133 capable chips
Date: Mon, 7 Dec 2009 19:36:13 +0100 [thread overview]
Message-ID: <200912071936.13575.bzolnier@gmail.com> (raw)
In-Reply-To: <20091207175314.2ef480e2@lxorguk.ukuu.org.uk>
On Monday 07 December 2009 06:53:14 pm Alan Cox wrote:
> > Hmm.. why cannot ->qc_issue be used here (like in all other host drivers with
> > shared PIO/MWDMA timings) instead of some new 'clipping'?
>
> Agreed it would probably work providing the 8bit timings are not affected
> by any of this.
If 8bit timings are a problem ->bmdma_{start,stop} approach can be used
instead (as done for similar reason in it821x IIRC).
> > ->qc_issue is the standard way to do it, takes care of more corner cases
> > and would also allow for faster MWDMA0 timings.
>
> All yours.. just revert the buggy patch and fix it. I won't have time to
> look at it until next year and I freecycled all my SiS hardware some time
> ago.
Thank you but this is quite a bit of work and I'm not interested personally.
--
Bartlomiej Zolnierkiewicz
next prev parent reply other threads:[~2009-12-07 18:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-30 13:22 [PATCH 0/6] ATA driver updates Alan Cox
2009-11-30 13:22 ` [PATCH 1/6] pata_via: Blacklist some combinations of Transcend Flash and via Alan Cox
2009-11-30 13:22 ` [PATCH 2/6] pata_sis: Implement MWDMA for the UDMA 133 capable chips Alan Cox
2009-12-07 13:26 ` Sergei Shtylyov
2009-12-07 15:05 ` Bartlomiej Zolnierkiewicz
2009-12-07 15:11 ` Bartlomiej Zolnierkiewicz
2009-12-07 15:36 ` Bartlomiej Zolnierkiewicz
2009-12-07 15:53 ` Bartlomiej Zolnierkiewicz
2009-12-07 16:34 ` Bartlomiej Zolnierkiewicz
2009-12-07 17:53 ` Alan Cox
2009-12-07 18:36 ` Bartlomiej Zolnierkiewicz [this message]
2009-11-30 13:22 ` [PATCH 3/6] cmd64x: implement serialization as per notes Alan Cox
2009-11-30 13:23 ` [PATCH 4/6] pata: Update experimental tags Alan Cox
2009-11-30 13:23 ` [PATCH 5/6] pata_ali: Fix regression with old devices Alan Cox
2009-11-30 13:23 ` [PATCH 6/6] pata_piccolo: Driver for old Toshiba chipsets Alan Cox
2009-12-03 7:36 ` Jeff Garzik
2009-12-03 9:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912071936.13575.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=alan@linux.intel.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).