From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Krzysztof Halasa <khc@pm.waw.pl>,
linux-ide@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: SATA_SIL on IXP425 workaround
Date: Thu, 14 Jan 2010 21:29:38 +0100 [thread overview]
Message-ID: <201001142129.38781.bzolnier@gmail.com> (raw)
In-Reply-To: <20100114192210.62593ead@lxorguk.ukuu.org.uk>
On Thursday 14 January 2010 08:22:10 pm Alan Cox wrote:
> > FWIW your patch is now in my atang tree (I'm aware that Jeff is working
> > on generic solution but in the meantime this non-intrusive patch allows
> > sata_sil to work on IXP425).
>
> I think this is the wrong place. If your platform can't do MMIO properly
> then the platform pci_iomap or pci quirk code should do the needed
> cleaning up, not put turds into the drivers. Why not just quirk it on your
> specific platform and clear the MMIO mapping.
I think that you misinterpreted the issue -- according to Krzysztof MMIO
works just fine, only 8/16-bit MMIO reads are a problem (please note that
using mixed PIO/MMIO access is still a win over pure PIO access and also
that sata_sil doesn't support pure non-MMIO operations currently)..
However if it gets fixed in the upstream kernel in some other way I'll
simply drop the patch during the next re-base of my tree (I just collect
ATA stuff that looks useful/interesting to me and which otherwise may
become lost)..
--
Bartlomiej Zolnierkiewicz
next prev parent reply other threads:[~2010-01-14 20:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 17:31 SATA_SIL on IXP425 workaround Krzysztof Halasa
2010-01-14 15:59 ` Bartlomiej Zolnierkiewicz
2010-01-14 18:08 ` Krzysztof Halasa
2010-01-14 19:22 ` Alan Cox
2010-01-14 20:12 ` Krzysztof Halasa
2010-01-14 21:05 ` Alan Cox
2010-01-16 5:03 ` Robert Hancock
2010-01-14 20:29 ` Bartlomiej Zolnierkiewicz [this message]
2010-01-14 21:00 ` Alan Cox
2010-01-21 5:00 ` Jeff Garzik
2010-01-21 4:58 ` Jeff Garzik
2010-01-21 6:48 ` Jeff Garzik
2010-01-21 18:37 ` Jeff Garzik
2010-01-21 21:47 ` Krzysztof Halasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001142129.38781.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=khc@pm.waw.pl \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).