From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 01/64] libata: fix CFA handling in ide_timing_compute() Date: Mon, 18 Jan 2010 20:04:39 +0100 Message-ID: <201001182004.40031.bzolnier@gmail.com> References: <20100118171349.14623.90030.sendpatchset@localhost> <201001181929.17136.bzolnier@gmail.com> <4B54AF06.3060800@ru.mvista.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ew0-f219.google.com ([209.85.219.219]:52684 "EHLO mail-ew0-f219.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754147Ab0ARTGI (ORCPT ); Mon, 18 Jan 2010 14:06:08 -0500 In-Reply-To: <4B54AF06.3060800@ru.mvista.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Sergei Shtylyov Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org On Monday 18 January 2010 07:57:10 pm Sergei Shtylyov wrote: > Bartlomiej Zolnierkiewicz wrote: > > >>> From: Bartlomiej Zolnierkiewicz > >>> Subject: [PATCH] libata: fix CFA handling in ide_timing_compute() > >>> > >>> Use standard cycle timing for CFA PIO5 and PIO6 modes. > >>> > >>> Based on commit 74638c8 for IDE subsystem. > >>> > >>> Signed-off-by: Bartlomiej Zolnierkiewicz > >>> --- > >>> drivers/ata/libata-core.c | 17 +++++++++++------ > >>> 1 file changed, 11 insertions(+), 6 deletions(-) > >>> > >>> Index: b/drivers/ata/libata-core.c > >>> =================================================================== > >>> --- a/drivers/ata/libata-core.c > >>> +++ b/drivers/ata/libata-core.c > >>> @@ -3211,6 +3211,7 @@ const struct ata_timing *ata_timing_find > >>> int ata_timing_compute(struct ata_device *adev, unsigned short speed, > >>> struct ata_timing *t, int T, int UT) > >>> { > >>> + const u16 *id = adev->id; > >>> const struct ata_timing *s; > >>> struct ata_timing p; > >>> > >>> @@ -3228,14 +3229,18 @@ int ata_timing_compute(struct ata_device > >>> * PIO/MW_DMA cycle timing. > >>> */ > >>> > >>> - if (adev->id[ATA_ID_FIELD_VALID] & 2) { /* EIDE drive */ > >>> + if (id[ATA_ID_FIELD_VALID] & 2) { /* EIDE drive */ > >>> memset(&p, 0, sizeof(p)); > >>> + > >>> if (speed >= XFER_PIO_0 && speed <= XFER_SW_DMA_0) { > >>> > >>> > >> BTW, shouldn't this actually be 'speed < XFER_SW_DMA_0'? > >> > > > > Good catch, I'll fix the patch later (would you be willing to fix > > ide-timings.c side of things?). > > > > I don't see what to fix there?.. Ah, sorry, ide-timings.c change is also not upstream yet.. -- Bartlomiej Zolnierkiewicz