From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 2/3] pata_pdc202xx_old: fix UDMA mode for PDC2026x chipsets Date: Sat, 13 Feb 2010 14:44:58 +0100 Message-ID: <201002131444.58139.bzolnier@gmail.com> References: <20100213133538.11564.94218.sendpatchset@localhost> <20100213133559.11564.54028.sendpatchset@localhost> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Return-path: Received: from fg-out-1718.google.com ([72.14.220.155]:8612 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755701Ab0BMNpW (ORCPT ); Sat, 13 Feb 2010 08:45:22 -0500 In-Reply-To: <20100213133559.11564.54028.sendpatchset@localhost> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: linux-ide@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Russell King On Saturday 13 February 2010 02:35:59 pm Bartlomiej Zolnierkiewicz wrote: > From: Bartlomiej Zolnierkiewicz > Subject: [PATCH] pata_pdc202xx_old: fix UDMA mode for PDC2026x chipsets > > PDC2026x chipsets need the same treatment as PDC20246 one. > > This is completely untested but will hopefully fix UDMA issues > that people have been reporting against pata_pdc202xx_old for > the last couple of years. > > Signed-off-by: Bartlomiej Zolnierkiewicz > --- > drivers/ata/pata_pdc202xx_old.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > Index: b/drivers/ata/pata_pdc202xx_old.c > =================================================================== > --- a/drivers/ata/pata_pdc202xx_old.c > +++ b/drivers/ata/pata_pdc202xx_old.c > @@ -26,7 +26,7 @@ > > #include "pata_pdc202xx_old.h" > > -static void pdc20246_exec_command(struct ata_port *ap, > +static void pdc202xx_exec_command(struct ata_port *ap, > const struct ata_taskfile *tf) > { > DPRINTK("ata%u: cmd 0x%X\n", ap->print_id, tf->command); > @@ -181,7 +181,7 @@ static struct ata_port_operations pdc202 > .set_piomode = pdc202xx_set_piomode, > .set_dmamode = pdc202xx_set_dmamode, > > - .sff_exec_command = pdc20246_exec_command, > + .sff_exec_command = pdc202xx_exec_command, > }; > > static struct ata_port_operations pdc2026x_port_ops = { the missing chunk :) @@ -195,6 +195,8 @@ .dev_config = pdc2026x_dev_config, .port_start = pdc2026x_port_start, + + .sff_exec_command = pdc202xx_exec_command, }; static int pdc202xx_init_one(struct pci_dev *dev, const struct pci_device_id *id)