From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-ide@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Alan Cox <alan@linux.intel.com>
Subject: Re: [git patches] libata updates for 2.6.34
Date: Fri, 5 Mar 2010 19:58:24 +0100 [thread overview]
Message-ID: <201003051958.24987.bzolnier@gmail.com> (raw)
In-Reply-To: <20100301202330.GA14977@havoc.gtf.org>
On Monday 01 March 2010 09:23:30 pm Jeff Garzik wrote:
> libata: Pass host flags into the pci helper
It introduces a subtle bug:
struct ata_host {
...
unsigned long flags;
> @@ -1642,8 +1643,8 @@ extern int ata_pci_sff_activate_host(struct ata_host *host,
> irq_handler_t irq_handler,
> struct scsi_host_template *sht);
> extern int ata_pci_sff_init_one(struct pci_dev *pdev,
> - const struct ata_port_info * const * ppi,
> - struct scsi_host_template *sht, void *host_priv);
> + const struct ata_port_info * const * ppi,
> + struct scsi_host_template *sht, void *host_priv, int hflags);
'int' type is not equal 'unsigned long' one on 64-bit architectures.
Besides doing it this way is clearly suboptimal as the same effect
could have been achieved by doing:
extern int __ata_pci_sff_init_one(struct pci_dev *pdev,
const struct ata_port_info * const *ppi,
struct scsi_host_template *sht, void *host_priv,
int hflag);
static inline int ata_pci_sff_init_one(struct pci_dev *pdev,
const struct ata_port_info * const *ppi,
struct scsi_host_template *sht, void *host_priv)
{
return __ata_pci_sff_init_one(pdev, ppi, sht, host_priv, 0);
}
without the need to update all drivers and without breaking pending
out-of-tree driver patches (yeah, it breaks my pata_ep93xx patches)..
--
Bartlomiej Zolnierkiewicz
next prev parent reply other threads:[~2010-03-05 19:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-01 20:23 [git patches] libata updates for 2.6.34 Jeff Garzik
2010-03-05 18:58 ` Bartlomiej Zolnierkiewicz [this message]
2010-03-05 18:37 ` Alan Cox
2010-03-05 19:43 ` Jeff Garzik
2010-03-05 20:12 ` Bartlomiej Zolnierkiewicz
2010-03-09 21:17 ` Linus Torvalds
2010-03-09 22:12 ` Jeff Garzik
2010-03-10 4:26 ` Tejun Heo
2010-03-12 0:16 ` Jeff Garzik
2010-03-15 2:55 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003051958.24987.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).