[PATCH] IDE: pass IRQ flags to the IDE core

[PATCH] IDE: pass IRQ flags to the IDE core

[Yegor Yefremov]

IDE: pass IRQ flags to the IDE core

This enables shared IRQs and other features to be used with platform devices

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>

Index: b/drivers/ide/ide_platform.c
===================================================================
--- a/drivers/ide/ide_platform.c	2010-04-02 01:02:33.000000000 +0200
+++ b/drivers/ide/ide_platform.c	2010-04-08 16:04:21.000000000 +0200
@@ -95,6 +95,7 @@
 	plat_ide_setup_ports(&hw, base, alt_base, pdata, res_irq->start);
 	hw.dev = &pdev->dev;

+	d.irq_flags = res_irq->flags;
 	if (mmio)
 		d.host_flags |= IDE_HFLAG_MMIO;

Re: [PATCH] IDE: pass IRQ flags to the IDE core

[David Miller]

From: Yegor Yefremov <yegorslists@googlemail.com>
Date: Thu, 8 Apr 2010 16:26:29 +0200

> IDE: pass IRQ flags to the IDE core
> 
> This enables shared IRQs and other features to be used with platform devices
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>

If you need this for a new device, please use the ATA layer
instead of adding support for new features in IDE which is
in deep maintainence mode only.

Thanks.

Re: [PATCH] IDE: pass IRQ flags to the IDE core

[Alan Cox]

On Thu, 15 Apr 2010 02:16:12 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:

> From: Yegor Yefremov <yegorslists@googlemail.com>
> Date: Thu, 8 Apr 2010 16:26:29 +0200
> 
> > IDE: pass IRQ flags to the IDE core
> > 
> > This enables shared IRQs and other features to be used with platform devices
> > 
> > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> 
> If you need this for a new device, please use the ATA layer
> instead of adding support for new features in IDE which is
> in deep maintainence mode only.

Actually Dave I think that one should go in. pata_platform (libata) and
ide_platform both match the same platform objects so you can flip between
them easily (eg for testing work). The fact the IRQ flags are only
honoured in libata but not in the matching IDE driver is probably a good
thing to fix.

Alan

Re: [PATCH] IDE: pass IRQ flags to the IDE core

[David Miller]

From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Date: Thu, 15 Apr 2010 12:07:48 +0100

> On Thu, 15 Apr 2010 02:16:12 -0700 (PDT)
> David Miller <davem@davemloft.net> wrote:
> 
>> From: Yegor Yefremov <yegorslists@googlemail.com>
>> Date: Thu, 8 Apr 2010 16:26:29 +0200
>> 
>> > IDE: pass IRQ flags to the IDE core
>> > 
>> > This enables shared IRQs and other features to be used with platform devices
>> > 
>> > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
>> 
>> If you need this for a new device, please use the ATA layer
>> instead of adding support for new features in IDE which is
>> in deep maintainence mode only.
> 
> Actually Dave I think that one should go in. pata_platform (libata) and
> ide_platform both match the same platform objects so you can flip between
> them easily (eg for testing work). The fact the IRQ flags are only
> honoured in libata but not in the matching IDE driver is probably a good
> thing to fix.

Ok, will apply this then.