From: David Miller <davem@davemloft.net>
To: sshtylyov@ru.mvista.com
Cc: linux-ide@vger.kernel.org, rmk@arm.linux.org.uk
Subject: Re: [PATCH 2/2] pdc202xx_old: ignore "FIFO empty" bit in test_irq() method
Date: Thu, 22 Apr 2010 19:12:36 -0700 (PDT) [thread overview]
Message-ID: <20100422.191236.183038347.davem@davemloft.net> (raw)
In-Reply-To: <201004141952.59445.sshtylyov@ru.mvista.com>
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Date: Wed, 14 Apr 2010 19:52:59 +0400
> The driver takes into account not only the interrupt status bit but also "FIFO
> empty" bit in its test_irq() method. This actually is a superfluous check since
> for the DMA commands calling the dma_test_irq() method further in the interrupt
> handler makes sure FIFO is emptied.
>
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>
> ---
> The patch is atop of ide-2.6.git tree...
>
> Russell, would you mind giving this patch a test?
Applied, but I don't want to push this out until there is
positive testing from Russell.
Russell, please test Sergei's patch, thanks!
next prev parent reply other threads:[~2010-04-23 2:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-14 15:52 [PATCH 2/2] pdc202xx_old: ignore "FIFO empty" bit in test_irq() method Sergei Shtylyov
2010-04-23 2:12 ` David Miller [this message]
2010-04-27 16:41 ` David Miller
2010-04-27 19:14 ` Mikael Pettersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100422.191236.183038347.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-ide@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox