From: Alan Cox <alan@linux.intel.com>
To: jeff@garzik.org, linux-ide@vger.kernel.org
Subject: [PATCH 1/3] libata: Remove excess delay in the tf_load path
Date: Wed, 05 May 2010 10:24:57 +0100 [thread overview]
Message-ID: <20100505092448.586.25299.stgit@localhost.localdomain> (raw)
In-Reply-To: <20100505092350.586.46344.stgit@localhost.localdomain>
We don't need to stall and wait after loading the task file and before
issuing a command, so don't do it. This shows up on profiles and is not
needed.
Signed-off-by: Alan Cox <alan@linux.intel.com>
---
drivers/ata/libata-sff.c | 3 ---
drivers/ata/pata_via.c | 2 --
2 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c
index b313896..17754a7 100644
--- a/drivers/ata/libata-sff.c
+++ b/drivers/ata/libata-sff.c
@@ -579,7 +579,6 @@ void ata_sff_tf_load(struct ata_port *ap, const struct ata_taskfile *tf)
if (ioaddr->ctl_addr)
iowrite8(tf->ctl, ioaddr->ctl_addr);
ap->last_ctl = tf->ctl;
- ata_wait_idle(ap);
}
if (is_addr && (tf->flags & ATA_TFLAG_LBA48)) {
@@ -615,8 +614,6 @@ void ata_sff_tf_load(struct ata_port *ap, const struct ata_taskfile *tf)
iowrite8(tf->device, ioaddr->device_addr);
VPRINTK("device 0x%X\n", tf->device);
}
-
- ata_wait_idle(ap);
}
EXPORT_SYMBOL_GPL(ata_sff_tf_load);
diff --git a/drivers/ata/pata_via.c b/drivers/ata/pata_via.c
index 741e7cb..87fb89e 100644
--- a/drivers/ata/pata_via.c
+++ b/drivers/ata/pata_via.c
@@ -417,8 +417,6 @@ static void via_tf_load(struct ata_port *ap, const struct ata_taskfile *tf)
tf->lbam,
tf->lbah);
}
-
- ata_wait_idle(ap);
}
static int via_port_start(struct ata_port *ap)
next prev parent reply other threads:[~2010-05-05 10:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 9:24 [PATCH 0/3] Resend: Libata delay patches Alan Cox
2010-05-05 9:24 ` Alan Cox [this message]
2010-05-05 10:24 ` [PATCH 1/3] libata: Remove excess delay in the tf_load path Sergei Shtylyov
2010-05-05 11:07 ` Alan Cox
2010-05-15 2:25 ` Jeff Garzik
2010-05-05 9:25 ` [PATCH 2/3] libata: Remove excess command issue delays Alan Cox
2010-05-15 2:24 ` Jeff Garzik
2010-05-15 14:09 ` Alan Cox
2010-05-17 22:21 ` Jeff Garzik
2010-06-10 20:01 ` Jeff Garzik
2010-05-05 9:25 ` [PATCH 3/3] libata: Make sil680 do its own exec_command posting Alan Cox
2010-05-15 2:34 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100505092448.586.25299.stgit@localhost.localdomain \
--to=alan@linux.intel.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).