From: David Miller <davem@davemloft.net>
To: bp@alien8.de
Cc: akpm@linux-foundation.org, hans42mueller@googlemail.com,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] ide-cd: Do not access completed requests in the irq handler
Date: Mon, 05 Jul 2010 21:24:05 -0700 (PDT) [thread overview]
Message-ID: <20100705.212405.232923099.davem@davemloft.net> (raw)
In-Reply-To: <20100703110104.GB25293@liondog.tnic>
From: Borislav Petkov <bp@alien8.de>
Date: Sat, 3 Jul 2010 13:01:04 +0200
> this came out as a by-product after debugging
> https://bugzilla.kernel.org/show_bug.cgi?id=16142
>
> It fixes the oops at
> https://bugzilla.kernel.org/attachment.cgi?id=26776, please apply.
>
> --
> From: Borislav Petkov <bp@alien8.de>
> Date: Fri, 2 Jul 2010 09:08:09 +0200
> Subject: [PATCH] ide-cd: Do not access completed requests in the irq handler
>
> ide_cd_error_cmd() can complete an erroneous request with leftover
> buffers. Signal this with its return value so that the request is not
> accessed after its completion in the irq handler and we oops.
>
> Cc: <stable@kernel.org> # 32.x 33.x 34.x
> Signed-off-by: Borislav Petkov <bp@alien8.de>
Applied, thanks Borislav.
next prev parent reply other threads:[~2010-07-06 4:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-17 8:07 [Bug 16142] r8169: Kernel Panic when a lot of data is transferred through network interface Borislav Petkov
[not found] ` <20100617150008.16a5e653@cpc>
2010-06-18 7:45 ` Borislav Petkov
2010-06-18 13:08 ` Hans Mueller
2010-06-18 15:02 ` Borislav Petkov
2010-06-18 22:50 ` Hans Mueller
2010-06-19 10:05 ` Borislav Petkov
2010-06-19 11:27 ` Hans Mueller
2010-06-23 8:02 ` Borislav Petkov
2010-06-25 16:58 ` Hans Mueller
2010-06-30 6:54 ` Borislav Petkov
2010-06-30 18:02 ` Hans Mueller
2010-06-30 18:31 ` Borislav Petkov
2010-07-03 7:49 ` Hans Mueller
2010-07-03 8:23 ` Borislav Petkov
2010-07-03 11:01 ` [PATCH] ide-cd: Do not access completed requests in the irq handler Borislav Petkov
2010-07-06 4:24 ` David Miller [this message]
2010-07-03 11:41 ` [Bug 16142] r8169: Kernel Panic when a lot of data is transferred through network interface Hans Mueller
2010-07-03 11:53 ` Borislav Petkov
2010-07-05 11:44 ` Hans Mueller
2010-07-05 12:11 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100705.212405.232923099.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=hans42mueller@googlemail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).