From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yann Dirson Subject: Re: [PATCH] via82cxxx: fix typo for VT6415 PCIE PATA IDE Host Controller support. Date: Tue, 20 Jul 2010 00:07:37 +0200 Message-ID: <20100719220736.GB3245@home.lan> References: <1279494644-3762-1-git-send-email-ydirson@altern.org> <20100718232838.GA3245@home.lan> <20100718.165620.133871819.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtp5-g21.free.fr ([212.27.42.5]:35019 "EHLO smtp5-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965985Ab0GSWCj (ORCPT ); Mon, 19 Jul 2010 18:02:39 -0400 Content-Disposition: inline In-Reply-To: <20100718.165620.133871819.davem@davemloft.net> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: David Miller Cc: linux-ide@vger.kernel.org On Sun, Jul 18, 2010 at 04:56:20PM -0700, David Miller wrote: > From: Yann Dirson > Date: Mon, 19 Jul 2010 01:28:38 +0200 > > > On Mon, Jul 19, 2010 at 01:13:24AM +0200, Yann Dirson wrote: > >> Without this fix, init of the via82cxxx driver causes a oops with a > >> stack resembling the one below, and the boot blocks between init of > >> USB devices and launch of init (was easy to bisect by booting with > >> init=/bin/sh). > > > > Looks like I was a bit too quick - this backtrace is not one of those > > I got without this fix (they never made it to the disk), but happens > > with the fix applied. > > The fix is still correct, so I'll leave it in the tree. OK, so let's hunt the remaining problem. Indeed I had not taken too much care of the context in the logs - full excerpt below, unbalanced enable for an IRQ which is shared with other things (ehci_hcd:usb1, ehci_hcd:usb3, ehci_hcd:usb5, ide0, ide1, firewire_ohci). Not sure if that matters, but I recall the oops I got before correcting the ID typo involved ohci. OTOH, we see here that the system believes in existence of "ide1", although the vt6415 appears to be single-channel (http://www.via.com.tw/en/products/peripherals/pci_pcie/vt6415/) I'll be adding a couple of printks and retest with frame-pointers, but in case someone already knows what's going on... :) WARNING: at kernel/irq/manage.c:274 enable_irq+0x3e/0x64() Hardware name: System Product Name Unbalanced enable for IRQ 17 Modules linked in: usbhid hid sd_mod crc_t10dif ohci_hcd thermal r8169 mii firewire_ohci(+) ahci firewire_core crc_itu_t ehci_hcd libata scsi_mod thermal_sys usbcore nls_base via82cxxx(+) ide_core Pid: 279, comm: work_for_cpu Not tainted 2.6.34.1-00003-ga42ea77 #2 Call Trace: [] ? warn_slowpath_common+0x76/0x8c [] ? warn_slowpath_fmt+0x40/0x45 [] ? printk+0x40/0x47 [] ? enable_irq+0x3e/0x64 [] ? ide_probe_port+0x55c/0x589 [ide_core] [] ? ide_host_register+0x273/0x628 [ide_core] [] ? ide_pci_init_two+0x4da/0x5c5 [ide_core] [] ? up+0xe/0x36 [] ? release_console_sem+0x17e/0x1ae [] ? klist_iter_exit+0x14/0x1e [] ? bus_find_device+0x75/0x83 [] ? via_init_one+0x269/0x28a [via82cxxx] [] ? init_chipset_via82cxxx+0x0/0x1ea [via82cxxx] [] ? do_work_for_cpu+0x0/0x1b [] ? local_pci_probe+0x12/0x16 [] ? do_work_for_cpu+0xb/0x1b [] ? kthread+0x75/0x7d [] ? kernel_thread_helper+0x4/0x10 [] ? kthread+0x0/0x7d [] ? kernel_thread_helper+0x0/0x10