From: Dan Carpenter <error27@gmail.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, alan@lxorguk.ukuu.org.uk
Subject: [patch] pata_winbond: fix module init
Date: Tue, 3 Aug 2010 17:27:47 +0200 [thread overview]
Message-ID: <20100803152549.GQ26313@bicker> (raw)
winbond_init_one() returns 0 on success and an error code on failure.
In the original code, we always just released the regions and return
-ENODEV. This was introduce in 2006 by 7e45b0e5f6f6 "[PATCH] libata:
Winbond support".
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
Compile tested.
diff --git a/drivers/ata/pata_winbond.c b/drivers/ata/pata_winbond.c
index 6d8619b..b34b594 100644
--- a/drivers/ata/pata_winbond.c
+++ b/drivers/ata/pata_winbond.c
@@ -248,9 +248,10 @@ static __init int winbond_init(void)
if (request_region(port, 2, "pata_winbond")) {
ret = winbond_init_one(port);
- if (ret <= 0)
+ if (ret < 0)
release_region(port, 2);
- else ct+= ret;
+ else
+ ct++;
}
}
}
next reply other threads:[~2010-08-03 15:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-03 15:27 Dan Carpenter [this message]
2010-08-16 19:23 ` [patch] pata_winbond: fix module init Bartlomiej Zolnierkiewicz
2010-08-17 6:29 ` Dan Carpenter
2010-08-17 10:07 ` Alan Cox
2010-08-17 17:39 ` Jeff Garzik
2010-08-17 21:52 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100803152549.GQ26313@bicker \
--to=error27@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jgarzik@pobox.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).