* [patch] pata_winbond: fix module init
@ 2010-08-03 15:27 Dan Carpenter
2010-08-16 19:23 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2010-08-03 15:27 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-ide, linux-kernel, kernel-janitors, alan
winbond_init_one() returns 0 on success and an error code on failure.
In the original code, we always just released the regions and return
-ENODEV. This was introduce in 2006 by 7e45b0e5f6f6 "[PATCH] libata:
Winbond support".
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
Compile tested.
diff --git a/drivers/ata/pata_winbond.c b/drivers/ata/pata_winbond.c
index 6d8619b..b34b594 100644
--- a/drivers/ata/pata_winbond.c
+++ b/drivers/ata/pata_winbond.c
@@ -248,9 +248,10 @@ static __init int winbond_init(void)
if (request_region(port, 2, "pata_winbond")) {
ret = winbond_init_one(port);
- if (ret <= 0)
+ if (ret < 0)
release_region(port, 2);
- else ct+= ret;
+ else
+ ct++;
}
}
}
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [patch] pata_winbond: fix module init
2010-08-03 15:27 [patch] pata_winbond: fix module init Dan Carpenter
@ 2010-08-16 19:23 ` Bartlomiej Zolnierkiewicz
2010-08-17 6:29 ` Dan Carpenter
2010-08-17 21:52 ` Jeff Garzik
0 siblings, 2 replies; 6+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2010-08-16 19:23 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Jeff Garzik, linux-ide, linux-kernel, kernel-janitors, alan
Hi Dan,
On Tuesday 03 August 2010 05:27:47 pm Dan Carpenter wrote:
> winbond_init_one() returns 0 on success and an error code on failure.
> In the original code, we always just released the regions and return
> -ENODEV. This was introduce in 2006 by 7e45b0e5f6f6 "[PATCH] libata:
> Winbond support".
You might like to pick up
http://patchwork.ozlabs.org/patch/39358/
instead..
Thanks.
--
Bartlomiej Zolnierkiewicz
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] pata_winbond: fix module init
2010-08-16 19:23 ` Bartlomiej Zolnierkiewicz
@ 2010-08-17 6:29 ` Dan Carpenter
2010-08-17 10:07 ` Alan Cox
2010-08-17 21:52 ` Jeff Garzik
1 sibling, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2010-08-17 6:29 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: Jeff Garzik, linux-ide, linux-kernel, kernel-janitors, alan
On Mon, Aug 16, 2010 at 09:23:03PM +0200, Bartlomiej Zolnierkiewicz wrote:
>
> Hi Dan,
>
> On Tuesday 03 August 2010 05:27:47 pm Dan Carpenter wrote:
> > winbond_init_one() returns 0 on success and an error code on failure.
> > In the original code, we always just released the regions and return
> > -ENODEV. This was introduce in 2006 by 7e45b0e5f6f6 "[PATCH] libata:
> > Winbond support".
>
> You might like to pick up
>
> http://patchwork.ozlabs.org/patch/39358/
>
> instead..
>
I don't have the hardware, but yes, probably it's better to replace this
driver since it has never been able to load.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] pata_winbond: fix module init
2010-08-17 6:29 ` Dan Carpenter
@ 2010-08-17 10:07 ` Alan Cox
2010-08-17 17:39 ` Jeff Garzik
0 siblings, 1 reply; 6+ messages in thread
From: Alan Cox @ 2010-08-17 10:07 UTC (permalink / raw)
To: Dan Carpenter
Cc: Bartlomiej Zolnierkiewicz, Jeff Garzik, linux-ide, linux-kernel,
kernel-janitors
On Tue, 17 Aug 2010 08:29:40 +0200
Dan Carpenter <error27@gmail.com> wrote:
> On Mon, Aug 16, 2010 at 09:23:03PM +0200, Bartlomiej Zolnierkiewicz wrote:
> >
> > Hi Dan,
> >
> > On Tuesday 03 August 2010 05:27:47 pm Dan Carpenter wrote:
> > > winbond_init_one() returns 0 on success and an error code on failure.
> > > In the original code, we always just released the regions and return
> > > -ENODEV. This was introduce in 2006 by 7e45b0e5f6f6 "[PATCH] libata:
> > > Winbond support".
> >
> > You might like to pick up
> >
> > http://patchwork.ozlabs.org/patch/39358/
> >
> > instead..
> >
>
> I don't have the hardware, but yes, probably it's better to replace this
> driver since it has never been able to load.
It was obsoleted into pata_legacy before it was ever finalised -
unfortunately I could then not get Jeff to delete it.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] pata_winbond: fix module init
2010-08-17 10:07 ` Alan Cox
@ 2010-08-17 17:39 ` Jeff Garzik
0 siblings, 0 replies; 6+ messages in thread
From: Jeff Garzik @ 2010-08-17 17:39 UTC (permalink / raw)
To: Alan Cox
Cc: Dan Carpenter, Bartlomiej Zolnierkiewicz, linux-ide, linux-kernel,
kernel-janitors
On 08/17/2010 06:07 AM, Alan Cox wrote:
> On Tue, 17 Aug 2010 08:29:40 +0200
> Dan Carpenter<error27@gmail.com> wrote:
>
>> On Mon, Aug 16, 2010 at 09:23:03PM +0200, Bartlomiej Zolnierkiewicz wrote:
>>>
>>> Hi Dan,
>>>
>>> On Tuesday 03 August 2010 05:27:47 pm Dan Carpenter wrote:
>>>> winbond_init_one() returns 0 on success and an error code on failure.
>>>> In the original code, we always just released the regions and return
>>>> -ENODEV. This was introduce in 2006 by 7e45b0e5f6f6 "[PATCH] libata:
>>>> Winbond support".
>>>
>>> You might like to pick up
>>>
>>> http://patchwork.ozlabs.org/patch/39358/
>>>
>>> instead..
>>>
>>
>> I don't have the hardware, but yes, probably it's better to replace this
>> driver since it has never been able to load.
>
> It was obsoleted into pata_legacy before it was ever finalised -
> unfortunately I could then not get Jeff to delete it.
Easy enough to delete now...
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] pata_winbond: fix module init
2010-08-16 19:23 ` Bartlomiej Zolnierkiewicz
2010-08-17 6:29 ` Dan Carpenter
@ 2010-08-17 21:52 ` Jeff Garzik
1 sibling, 0 replies; 6+ messages in thread
From: Jeff Garzik @ 2010-08-17 21:52 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: Dan Carpenter, linux-ide, linux-kernel, kernel-janitors, alan
On 08/16/2010 03:23 PM, Bartlomiej Zolnierkiewicz wrote:
>
> Hi Dan,
>
> On Tuesday 03 August 2010 05:27:47 pm Dan Carpenter wrote:
>> winbond_init_one() returns 0 on success and an error code on failure.
>> In the original code, we always just released the regions and return
>> -ENODEV. This was introduce in 2006 by 7e45b0e5f6f6 "[PATCH] libata:
>> Winbond support".
>
> You might like to pick up
>
> http://patchwork.ozlabs.org/patch/39358/
Picked it up...
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-08-17 21:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-03 15:27 [patch] pata_winbond: fix module init Dan Carpenter
2010-08-16 19:23 ` Bartlomiej Zolnierkiewicz
2010-08-17 6:29 ` Dan Carpenter
2010-08-17 10:07 ` Alan Cox
2010-08-17 17:39 ` Jeff Garzik
2010-08-17 21:52 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).