linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <w.sang@pengutronix.de>
To: David Miller <davem@davemloft.net>
Cc: linux-ide@vger.kernel.org, bzolnier@gmail.com
Subject: Re: WARNINGs because of ide-proc handling
Date: Fri, 3 Sep 2010 20:59:34 +0200	[thread overview]
Message-ID: <20100903185934.GA27291@pengutronix.de> (raw)
In-Reply-To: <20100903.073503.191401190.davem@davemloft.net>

[-- Attachment #1: Type: text/plain, Size: 1563 bytes --]

On Fri, Sep 03, 2010 at 07:35:03AM -0700, David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Fri, 03 Sep 2010 05:34:37 -0700 (PDT)
> 
> > From: Wolfram Sang <w.sang@pengutronix.de>
> > Date: Fri, 3 Sep 2010 07:53:28 +0200
> > 
> >> 
> >>> Thanks for your analysis and suggested patch, I'll take a look at this.
> >> 
> >> Thanks for your help. If we can't find something, I'll just do a bisect this
> >> weekend.
> > 
> > Frankly, at this point, I'm beginning suspect that the procfs stuff
> > simply never warned at some point in the past and that the IDE
> > code has had this problem for a while.
> 
> I just confirmed that the procfs code only started warning on removal
> of non-present entries this past March, so basically the IDE code has
> silently had this problem of not actually creating any of it's procfs
> nodes for some time now.

Confirming. With 2.6.33, I don't get the warnings, but neither get the
procfs-entries.

Checking my debug-output again, I assume that the hard-disk has the entries,
because it is the first user of ide-gd, so that driver still needs to be
requested. Maybe this is enough delay for the directories to appear? Wild
guess...

> Wolfram I'll look into your patch some more and integrate it, thanks.

Just in case you need a SoB:

Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>

Thanks,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

  parent reply	other threads:[~2010-09-03 18:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-31 20:56 WARNINGs because of ide-proc handling Wolfram Sang
2010-09-02  2:33 ` David Miller
2010-09-02 21:28   ` Wolfram Sang
2010-09-02 22:14     ` David Miller
2010-09-03  5:53       ` Wolfram Sang
2010-09-03 12:34         ` David Miller
2010-09-03 14:21           ` Bartlomiej Zolnierkiewicz
2010-09-03 14:35           ` David Miller
2010-09-03 14:47             ` Wolfram Sang
2010-09-03 18:59             ` Wolfram Sang [this message]
2010-09-14  4:17               ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100903185934.GA27291@pengutronix.de \
    --to=w.sang@pengutronix.de \
    --cc=bzolnier@gmail.com \
    --cc=davem@davemloft.net \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).