* [PATCH 3/4] pata_sil680: implement sff_irq_check() method
@ 2010-10-08 15:01 Sergei Shtylyov
2010-10-08 16:36 ` Alan Cox
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2010-10-08 15:01 UTC (permalink / raw)
To: jgarzik; +Cc: linux-ide
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
---
The patch is against the recent Linus' tree.
drivers/ata/pata_sil680.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
Index: linux-2.6/drivers/ata/pata_sil680.c
===================================================================
--- linux-2.6.orig/drivers/ata/pata_sil680.c
+++ linux-2.6/drivers/ata/pata_sil680.c
@@ -210,6 +210,17 @@ static void sil680_sff_exec_command(stru
ioread8(ap->ioaddr.bmdma_addr + ATA_DMA_CMD);
}
+static bool sil680_sff_irq_check(struct ata_port *ap)
+{
+ struct pci_dev *pdev = to_pci_dev(ap->host->dev);
+ unsigned long addr = sil680_selreg(ap, 1);
+ u8 val;
+
+ pci_read_config_byte(pdev, addr, &val);
+
+ return val & 0x08;
+}
+
static struct scsi_host_template sil680_sht = {
ATA_BMDMA_SHT(DRV_NAME),
};
@@ -218,6 +229,7 @@ static struct scsi_host_template sil680_
static struct ata_port_operations sil680_port_ops = {
.inherits = &ata_bmdma32_port_ops,
.sff_exec_command = sil680_sff_exec_command,
+ .sff_irq_check = sil680_sff_irq_check,
.cable_detect = sil680_cable_detect,
.set_piomode = sil680_set_piomode,
.set_dmamode = sil680_set_dmamode,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 3/4] pata_sil680: implement sff_irq_check() method
2010-10-08 15:01 [PATCH 3/4] pata_sil680: implement sff_irq_check() method Sergei Shtylyov
@ 2010-10-08 16:36 ` Alan Cox
2010-10-09 12:14 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Alan Cox @ 2010-10-08 16:36 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: jgarzik, linux-ide
On Fri, 8 Oct 2010 19:01:08 +0400
Sergei Shtylyov <sshtylyov@ru.mvista.com> wrote:
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>
> ---
> The patch is against the recent Linus' tree.
Same question again for these other two - test environment, results,
reason it is needed ?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 3/4] pata_sil680: implement sff_irq_check() method
2010-10-08 16:36 ` Alan Cox
@ 2010-10-09 12:14 ` Sergei Shtylyov
0 siblings, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2010-10-09 12:14 UTC (permalink / raw)
To: Alan Cox; +Cc: jgarzik, linux-ide
Hello.
On 08-10-2010 20:36, Alan Cox wrote:
>> Signed-off-by: Sergei Shtylyov<sshtylyov@ru.mvista.com>
>> ---
>> The patch is against the recent Linus' tree.
> Same question again for these other two - test environment, results,
> reason it is needed ?
Answered under the pata_cmd640 patch thread.
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-09 12:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-08 15:01 [PATCH 3/4] pata_sil680: implement sff_irq_check() method Sergei Shtylyov
2010-10-08 16:36 ` Alan Cox
2010-10-09 12:14 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).